Fix constant evaluation of template string expressions #58500

ahejlsberg · 2024-05-11T17:45:28Z

ahejlsberg · 2024-05-11T17:45:39Z

typescript-bot · 2024-05-11T17:45:41Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-11T18:04:36Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-11T18:05:55Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58500/merge:

Everything looks good!

typescript-bot · 2024-05-11T18:21:40Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,287k (± 0.07%)}	_{192,800k (± 0.76%)}	_~	_192,164k	_195,793k	_{p=0.748 n=6}
_{Parse Time}	_{1.29s (± 1.24%)}	_{1.30s (± 1.23%)}	_~	_1.27s	_1.31s	_{p=0.503 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.44%)}	_{9.56s (± 0.33%)}	_~	_9.53s	_9.61s	_{p=1.000 n=6}
_{Emit Time}	_{2.64s (± 0.65%)}	_{2.64s (± 0.81%)}	_~	_2.62s	_2.67s	_{p=1.000 n=6}
_{Total Time}	_{14.22s (± 0.27%)}	_{14.22s (± 0.18%)}	_~	_14.18s	_14.25s	_{p=0.936 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,086k (± 0.01%)}	_{1,222,078k (± 0.01%)}	_~	_1,221,982k	_1,222,156k	_{p=0.936 n=6}
_{Parse Time}	_{6.79s (± 0.53%)}	_{6.75s (± 0.24%)}	_~	_6.73s	_6.77s	_{p=0.101 n=6}
_{Bind Time}	_{1.88s (± 0.43%)}	_{1.88s (± 0.29%)}	_~	_1.87s	_1.88s	_{p=0.859 n=6}
_{Check Time}	_{31.24s (± 0.55%)}	_{31.34s (± 0.67%)}	_~	_31.11s	_31.64s	_{p=0.521 n=6}
_{Emit Time}	_{14.77s (± 0.51%)}	_{14.82s (± 0.76%)}	_~	_14.71s	_15.03s	_{p=1.000 n=6}
_{Total Time}	_{54.67s (± 0.42%)}	_{54.79s (± 0.40%)}	_~	_54.43s	_55.03s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,961,283	_1,961,283	_~	_~	_~	_{p=1.000 n=6}
_Types	_696,900	_696,902	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,778,031k (± 0.00%)}	_{1,778,041k (± 0.00%)}	_~	_1,778,024k	_1,778,063k	_{p=0.378 n=6}
_{Parse Time}	_{6.78s (± 0.29%)}	_{6.78s (± 0.16%)}	_~	_6.76s	_6.79s	_{p=0.788 n=6}
_{Bind Time}	_{2.30s (± 0.59%)}	_{2.31s (± 0.69%)}	_~	_2.28s	_2.32s	_{p=0.057 n=6}
_{Check Time}	_{57.07s (± 0.58%)}	_{57.28s (± 0.53%)}	_~	_56.81s	_57.69s	_{p=0.261 n=6}
_{Emit Time}	_0.14s	_{0.14s (± 3.77%)}	_~	_0.14s	_0.15s	_{p=0.071 n=6}
_{Total Time}	_{66.29s (± 0.51%)}	_{66.52s (± 0.47%)}	_~	_66.03s	_66.94s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,211	_259,212	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,336,162k (± 0.01%)}	_{2,336,723k (± 0.04%)}	_~	_2,335,601k	_2,338,251k	_{p=0.173 n=6}
_{Parse Time}	_{5.02s (± 0.78%)}	_{5.03s (± 1.16%)}	_~	_4.96s	_5.12s	_{p=0.873 n=6}
_{Bind Time}	_{1.87s (± 0.59%)}	_{1.88s (± 0.73%)}	_~	_1.85s	_1.89s	_{p=0.365 n=6}
_{Check Time}	_{33.77s (± 0.41%)}	_{33.79s (± 0.38%)}	_~	_33.65s	_33.99s	_{p=0.936 n=6}
_{Emit Time}	_{2.68s (± 1.29%)}	_{2.64s (± 1.56%)}	_~	_2.56s	_2.67s	_{p=0.258 n=6}
_{Total Time}	_{43.35s (± 0.31%)}	_{43.34s (± 0.31%)}	_~	_43.20s	_43.54s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,211	_259,212	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,412,446k (± 0.02%)}	_{2,412,555k (± 0.02%)}	_~	_2,411,968k	_2,413,078k	_{p=0.936 n=6}
_{Parse Time}	_{6.28s (± 1.64%)}	_{6.25s (± 0.78%)}	_~	_6.16s	_6.31s	_{p=0.378 n=6}
_{Bind Time}	_{2.03s (± 0.51%)}	_{2.07s (± 1.45%)}	_~	_2.01s	_2.09s	_{p=0.052 n=6}
_{Check Time}	_{40.20s (± 0.25%)}	_{40.23s (± 0.34%)}	_~	_40.10s	_40.43s	_{p=0.873 n=6}
_{Emit Time}	_{3.20s (± 1.67%)}	_{3.16s (± 2.05%)}	_~	_3.06s	_3.23s	_{p=0.228 n=6}
_{Total Time}	_{51.70s (± 0.44%)}	_{51.70s (± 0.28%)}	_~	_51.55s	_51.96s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,716	_256,716	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,288	_104,288	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{425,813k (± 0.02%)}	_{425,846k (± 0.03%)}	_~	_425,712k	_426,018k	_{p=0.630 n=6}
_{Parse Time}	_{4.16s (± 0.81%)}	_{4.17s (± 0.28%)}	_~	_4.16s	_4.19s	_{p=0.557 n=6}
_{Bind Time}	_{1.61s (± 1.28%)}	_{1.61s (± 0.55%)}	_~	_1.60s	_1.62s	_{p=0.566 n=6}
_{Check Time}	_{22.20s (± 0.29%)}	_{22.14s (± 0.51%)}	_~	_21.93s	_22.25s	_{p=0.630 n=6}
_{Emit Time}	_{1.72s (± 2.02%)}	_{1.72s (± 1.02%)}	_~	_1.69s	_1.74s	_{p=0.412 n=6}
_{Total Time}	_{29.69s (± 0.30%)}	_{29.65s (± 0.40%)}	_~	_29.45s	_29.76s	_{p=0.688 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,822k (± 0.04%)}	_{369,923k (± 0.04%)}	_~	_369,813k	_370,177k	_{p=0.378 n=6}
_{Parse Time}	_{2.84s (± 0.54%)}	_{2.81s (± 1.16%)}	_~	_2.77s	_2.85s	_{p=0.225 n=6}
_{Bind Time}	_{1.59s (± 0.76%)}	_{1.58s (± 0.62%)}	_~	_1.57s	_1.59s	_{p=0.246 n=6}
_{Check Time}	_{15.65s (± 0.43%)}	_{15.66s (± 0.21%)}	_~	_15.61s	_15.71s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.08s (± 0.41%)}	_{20.06s (± 0.27%)}	_~	_19.96s	_20.10s	_{p=0.470 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,821,183	_2,821,183	_~	_~	_~	_{p=1.000 n=6}
_Types	_957,007	_957,009	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,992,968k (± 0.00%)}	_{2,993,027k (± 0.00%)}	_~	_2,992,943k	_2,993,199k	_{p=0.230 n=6}
_{Parse Time}	_{13.85s (± 0.18%)}	_{13.83s (± 0.36%)}	_~	_13.76s	_13.89s	_{p=0.373 n=6}
_{Bind Time}	_{4.15s (± 2.03%)}	_{4.12s (± 0.36%)}	_~	_4.10s	_4.14s	_{p=0.806 n=6}
_{Check Time}	_{73.13s (± 0.26%)}	_{73.22s (± 0.54%)}	_~	_72.73s	_73.83s	_{p=0.810 n=6}
_{Emit Time}	_{23.50s (± 0.49%)}	_{23.60s (± 0.85%)}	_~	_23.35s	_23.92s	_{p=0.297 n=6}
_{Total Time}	_{114.62s (± 0.17%)}	_{114.77s (± 0.41%)}	_~	_114.35s	_115.42s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,637k (± 0.03%)}	_{410,598k (± 0.02%)}	_~	_410,526k	_410,692k	_{p=0.575 n=6}
_{Parse Time}	_{4.74s (± 0.71%)}	_{4.75s (± 0.34%)}	_~	_4.72s	_4.77s	_{p=0.678 n=6}
_{Bind Time}	_{2.04s (± 1.57%)}	_{2.06s (± 0.78%)}	_~	_2.03s	_2.07s	_{p=0.571 n=6}
_{Check Time}	_{20.96s (± 0.36%)}	_{20.95s (± 0.28%)}	_~	_20.87s	_21.02s	_{p=0.873 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.74s (± 0.28%)}	_{27.75s (± 0.24%)}	_~	_27.69s	_27.84s	_{p=0.418 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,576	_524,576	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,847	_178,847	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,593k (± 0.01%)}	_{462,621k (± 0.01%)}	_~	_462,569k	_462,743k	_{p=0.575 n=6}
_{Parse Time}	_{3.12s (± 0.44%)}	_{3.13s (± 1.06%)}	_~	_3.08s	_3.17s	_{p=0.280 n=6}
_{Bind Time}	_1.16s	_{1.17s (± 1.26%)}	_~	_1.15s	_1.19s	_{p=0.128 n=6}
_{Check Time}	_{18.36s (± 0.36%)}	_{18.17s (± 0.64%)}	_{-0.19s (- 1.03%)}	_18.04s	_18.35s	_{p=0.016 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.64s (± 0.27%)}	_{22.48s (± 0.51%)}	_{-0.16s (- 0.70%)}	_22.36s	_22.64s	_{p=0.045 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-11T19:22:45Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58500/merge:

Everything looks good!

ahejlsberg added 2 commits May 11, 2024 10:16

Perform constant evaluation first

be4006d

Add tests

65757f0

typescript-bot assigned ahejlsberg May 11, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 11, 2024

jakebailey approved these changes May 13, 2024

View reviewed changes

ahejlsberg merged commit d90e8e7 into main May 14, 2024
28 checks passed

ahejlsberg deleted the fix58494 branch May 14, 2024 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix constant evaluation of template string expressions #58500

Fix constant evaluation of template string expressions #58500

ahejlsberg commented May 11, 2024

ahejlsberg commented May 11, 2024

typescript-bot commented May 11, 2024 •

edited

Loading

typescript-bot commented May 11, 2024

typescript-bot commented May 11, 2024

typescript-bot commented May 11, 2024

tsc

typescript-bot commented May 11, 2024

Fix constant evaluation of template string expressions #58500

Fix constant evaluation of template string expressions #58500

Conversation

ahejlsberg commented May 11, 2024

ahejlsberg commented May 11, 2024

typescript-bot commented May 11, 2024 • edited Loading

typescript-bot commented May 11, 2024

typescript-bot commented May 11, 2024

typescript-bot commented May 11, 2024

tsc

typescript-bot commented May 11, 2024

typescript-bot commented May 11, 2024 •

edited

Loading