Revert "Fixed apparent type of homomorphic mapped type with non-homomorphic instantiation (#56727)" and add test #57092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
approved these changes
Jan 19, 2024
jakebailey
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Isn't it confusing to have tests that are kinda meant to pass but they fail?
There was a problem hiding this comment.
Well the fact that the test was added meant that the behavior wasn't tested in the first place. Capturing the behavior and changes over time is useful.
There was a problem hiding this comment.
I'll remember to leave the tests in the future.
ahejlsberg
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56727 breaks @types/sinon version 10: #56727 (comment)
This PR reverts that one, and adds a test with a simplified version of the code that broke (test thanks to @Andarist).