-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check auto-import completion for spread assignment #56247
Conversation
Co-authored-by: Daniel Rosenwasser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case for
const test7: { foo: string } = { foo/*7*/ }
I think we don’t expect an auto-import there.
I tried this test case and it can make an auto-import. Maybe the type of |
@typescript-bot pack this |
Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 1ed01ac. You can monitor the build here. |
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Hm, I just tried it locally and I don’t get an auto-import. Can you add the test so I can see what’s going on? |
Yeah, sure. Seens that the test case isn't right. I changed it, it should works now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hanzooo!
Co-authored-by: Daniel Rosenwasser <[email protected]>
Fixes #56071