Use contextual type to determine 'this' when determining member visibility #56105

RyanCavanaugh · 2023-10-13T21:26:59Z

jakebailey · 2023-10-13T23:01:59Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-10-13T23:02:02Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 215a87a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-13T23:02:02Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 215a87a. You can monitor the build here.

typescript-bot · 2023-10-13T23:02:02Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 215a87a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-13T23:02:02Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 215a87a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-13T23:02:02Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 215a87a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-13T23:04:05Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158213/artifacts?artifactName=tgz&fileId=2B01F3860C4B0C5B3A6229C8DF6BFAA5BC2A8EA40AEA4C5568770C359EFD3E5702&fileName=/typescript-5.3.0-insiders.20231013.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-10-13T23:22:00Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56105/merge:

There were infrastructure failures potentially unrelated to your change:

3 instances of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2023-10-13T23:28:29Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,071k (± 0.01%)}	_{295,099k (± 0.01%)}	_~	_295,073k	_295,127k	_{p=0.196 n=6}
_{Parse Time}	_{2.63s (± 0.61%)}	_{2.64s (± 0.28%)}	_~	_2.63s	_2.65s	_{p=0.282 n=6}
_{Bind Time}	_{0.84s (± 0.97%)}	_{0.84s (± 0.97%)}	_~	_0.83s	_0.85s	_{p=1.000 n=6}
_{Check Time}	_{8.06s (± 0.47%)}	_{8.06s (± 0.22%)}	_~	_8.03s	_8.08s	_{p=0.809 n=6}
_{Emit Time}	_{7.05s (± 0.47%)}	_{7.04s (± 0.15%)}	_~	_7.03s	_7.06s	_{p=0.416 n=6}
_{Total Time}	_{18.59s (± 0.27%)}	_{18.59s (± 0.08%)}	_~	_18.56s	_18.60s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,529k (± 1.64%)}	_{193,044k (± 1.51%)}	_~	_190,614k	_196,713k	_{p=0.936 n=6}
_{Parse Time}	_{1.35s (± 0.61%)}	_{1.35s (± 0.56%)}	_~	_1.34s	_1.36s	_{p=0.729 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.11s (± 0.39%)}	_{9.14s (± 0.31%)}	_~	_9.11s	_9.18s	_{p=0.106 n=6}
_{Emit Time}	_{2.64s (± 0.95%)}	_{2.64s (± 0.54%)}	_~	_2.62s	_2.66s	_{p=0.570 n=6}
_{Total Time}	_{13.82s (± 0.41%)}	_{13.86s (± 0.15%)}	_~	_13.83s	_13.88s	_{p=0.065 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,299k (± 0.00%)}	_{347,319k (± 0.00%)}	_~	_347,295k	_347,335k	_{p=0.065 n=6}
_{Parse Time}	_{2.45s (± 0.36%)}	_{2.46s (± 0.65%)}	_~	_2.44s	_2.48s	_{p=0.360 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.91s (± 0.54%)}	_{6.93s (± 0.55%)}	_~	_6.88s	_6.96s	_{p=0.685 n=6}
_{Emit Time}	_{4.02s (± 0.26%)}	_{4.02s (± 0.44%)}	_~	_4.00s	_4.04s	_{p=0.801 n=6}
_{Total Time}	_{14.32s (± 0.25%)}	_{14.34s (± 0.28%)}	_~	_14.29s	_14.39s	_{p=0.470 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,554k (± 0.01%)}	_{302,556k (± 0.01%)}	_~	_302,536k	_302,597k	_{p=0.748 n=6}
_{Parse Time}	_{2.01s (± 0.93%)}	_{1.99s (± 0.49%)}	_{-0.03s (- 1.32%)}	_1.98s	_2.00s	_{p=0.033 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 1.21%)}	_~	_0.99s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{6.27s (± 0.32%)}	_{6.26s (± 0.38%)}	_~	_6.23s	_6.30s	_{p=0.466 n=6}
_{Emit Time}	_{3.56s (± 0.59%)}	_{3.57s (± 0.34%)}	_~	_3.55s	_3.58s	_{p=0.514 n=6}
_{Total Time}	_{12.85s (± 0.21%)}	_{12.81s (± 0.16%)}	_~	_12.79s	_12.84s	_{p=0.061 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,505k (± 0.01%)}	_{470,494k (± 0.00%)}	_~	_470,472k	_470,514k	_{p=0.689 n=6}
_{Parse Time}	_{2.58s (± 0.47%)}	_{2.58s (± 0.32%)}	_~	_2.57s	_2.59s	_{p=0.175 n=6}
_{Bind Time}	_{1.00s (± 1.09%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.604 n=6}
_{Check Time}	_{16.62s (± 0.60%)}	_{16.59s (± 0.45%)}	_~	_16.51s	_16.70s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.48%)}	_{20.17s (± 0.38%)}	_~	_20.10s	_20.30s	_{p=0.688 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,670k (± 0.02%)}	_{512,651k (± 0.01%)}	_~	_512,578k	_512,706k	_{p=0.936 n=6}
_{Parse Time}	_{3.26s (± 0.23%)}	_{3.26s (± 0.32%)}	_~	_3.25s	_3.28s	_{p=0.931 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.71%)}	_~	_1.53s	_1.56s	_{p=1.000 n=6}
_{Check Time}	_{2.88s (± 0.69%)}	_{2.85s (± 0.95%)}	_~	_2.81s	_2.88s	_{p=0.063 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.77s (± 0.18%)}	_{7.73s (± 0.39%)}	_{-0.03s (- 0.41%)}	_7.70s	_7.76s	_{p=0.033 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,377ms (± 1.63%)}	_{2,351ms (± 1.09%)}	_~	_2,329ms	_2,399ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{5,343ms (± 1.63%)}	_{5,408ms (± 1.59%)}	_~	_5,280ms	_5,474ms	_{p=0.173 n=6}
_{Req 3 - references}	_{328ms (± 0.80%)}	_{329ms (± 1.49%)}	_~	_325ms	_337ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{279ms (± 1.51%)}	_{276ms (± 1.38%)}	_~	_273ms	_282ms	_{p=0.193 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (±10.05%)}	_{85ms (± 9.10%)}	_~	_75ms	_90ms	_{p=0.190 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,476ms (± 1.62%)}	_{2,487ms (± 1.13%)}	_~	_2,458ms	_2,539ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,129ms (± 2.00%)}	_{4,082ms (± 1.55%)}	_~	_4,045ms	_4,210ms	_{p=0.468 n=6}
_{Req 3 - references}	_{338ms (± 1.80%)}	_{342ms (± 1.27%)}	_~	_333ms	_344ms	_{p=0.181 n=6}
_{Req 4 - navto}	_{284ms (± 0.73%)}	_{284ms (± 0.36%)}	_~	_283ms	_286ms	_{p=0.738 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 7.15%)}	_{85ms (± 5.42%)}	_~	_76ms	_88ms	_{p=0.304 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,595ms (± 0.49%)}	_{2,583ms (± 0.62%)}	_~	_2,567ms	_2,604ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{1,677ms (± 2.16%)}	_{1,677ms (± 1.76%)}	_~	_1,634ms	_1,711ms	_{p=0.810 n=6}
_{Req 3 - references}	_{109ms (± 7.48%)}	_{119ms (± 9.01%)}	_~	_105ms	_128ms	_{p=0.285 n=6}
_{Req 4 - navto}	_{359ms (± 0.34%)}	_{359ms (± 0.45%)}	_~	_358ms	_362ms	_{p=0.933 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{302ms (± 2.01%)}	_{306ms (± 1.79%)}	_~	_295ms	_310ms	_{p=0.329 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.28ms (± 0.18%)}	_{152.22ms (± 0.18%)}	_{-0.06ms (- 0.04%)}	_151.25ms	_156.43ms	_{p=0.022 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.84ms (± 0.16%)}	_{227.69ms (± 0.17%)}	_{-0.16ms (- 0.07%)}	_226.30ms	_235.38ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.85ms (± 0.17%)}	_{228.81ms (± 0.16%)}	_~	_227.37ms	_233.27ms	_{p=0.261 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.72ms (± 0.16%)}	_{228.84ms (± 0.16%)}	_{+0.12ms (+ 0.05%)}	_227.37ms	_234.47ms	_{p=0.002 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-10-14T00:17:10Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-10-14T01:16:32Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56105/merge:

Everything looks good!

sandersn · 2023-11-03T17:52:13Z

src/compiler/checker.ts

+            }
+        }
+        else {
+            // 3. This 'this' parameter of a contextual type


Suggested change

// 3. This 'this' parameter of a contextual type

// 3. The 'this' parameter of a contextual type

sandersn · 2023-12-04T19:12:13Z

@RyanCavanaugh this looks like it's ready to merge. Is that right?

…ility Fixes microsoft#56094

RyanCavanaugh · 2024-08-02T19:55:02Z

@typescript-bot test this

typescript-bot · 2024-08-02T19:55:06Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-02T20:16:22Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-02T20:19:54Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/56105/merge:

Everything looks good!

typescript-bot · 2024-08-02T20:32:03Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,338k (± 0.09%)}	_{194,090k (± 0.98%)}	_{+1,752k (+ 0.91%)}	_192,313k	_195,856k	_{p=0.030 n=6}
_{Parse Time}	_{1.95s (± 0.60%)}	_{1.95s (± 0.54%)}	_~	_1.93s	_1.96s	_{p=0.619 n=6}
_{Bind Time}	_{1.06s (± 0.93%)}	_{1.05s (± 0.79%)}	_~	_1.05s	_1.07s	_{p=0.588 n=6}
_{Check Time}	_{13.99s (± 0.44%)}	_{13.97s (± 0.40%)}	_~	_13.89s	_14.02s	_{p=0.688 n=6}
_{Emit Time}	_{3.99s (± 1.31%)}	_{3.99s (± 1.52%)}	_~	_3.88s	_4.04s	_{p=0.872 n=6}
_{Total Time}	_{20.99s (± 0.31%)}	_{20.96s (± 0.38%)}	_~	_20.87s	_21.07s	_{p=0.373 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,537	_945,537	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,512	_409,512	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,221k (± 0.01%)}	_{1,222,270k (± 0.00%)}	_~	_1,222,211k	_1,222,294k	_{p=0.229 n=6}
_{Parse Time}	_{7.94s (± 1.00%)}	_{7.91s (± 0.39%)}	_~	_7.88s	_7.96s	_{p=0.936 n=6}
_{Bind Time}	_{2.23s (± 0.60%)}	_{2.23s (± 0.46%)}	_~	_2.21s	_2.24s	_{p=1.000 n=6}
_{Check Time}	_{36.22s (± 0.31%)}	_{36.30s (± 0.29%)}	_~	_36.20s	_36.40s	_{p=0.226 n=6}
_{Emit Time}	_{17.83s (± 0.27%)}	_{17.79s (± 0.31%)}	_~	_17.72s	_17.88s	_{p=0.199 n=6}
_{Total Time}	_{64.22s (± 0.25%)}	_{64.23s (± 0.20%)}	_~	_64.04s	_64.40s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,483,478	_2,483,478	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,012,731	_1,012,731	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,475,470k (± 0.01%)}	_{2,475,416k (± 0.00%)}	_~	_2,475,366k	_2,475,462k	_{p=0.471 n=6}
_{Parse Time}	_{10.39s (± 0.58%)}	_{10.39s (± 0.56%)}	_~	_10.34s	_10.49s	_{p=1.000 n=6}
_{Bind Time}	_{2.60s (± 0.49%)}	_{2.61s (± 0.51%)}	_~	_2.59s	_2.62s	_{p=0.383 n=6}
_{Check Time}	_{89.53s (± 1.65%)}	_{89.61s (± 1.53%)}	_~	_88.13s	_91.93s	_{p=0.936 n=6}
_{Emit Time}	_{0.33s (± 1.58%)}	_{0.33s (± 1.68%)}	_~	_0.32s	_0.33s	_{p=0.640 n=6}
_{Total Time}	_{102.85s (± 1.41%)}	_{102.93s (± 1.38%)}	_~	_101.41s	_105.30s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,170	_1,229,171	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,285	_264,285	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,526,692k (±11.74%)}	_{2,527,270k (±11.74%)}	_~	_2,348,516k	_3,059,422k	_{p=0.575 n=6}
_{Parse Time}	_{7.58s (± 1.13%)}	_{7.54s (± 1.15%)}	_~	_7.47s	_7.71s	_{p=0.261 n=6}
_{Bind Time}	_{2.78s (± 1.15%)}	_{2.78s (± 1.16%)}	_~	_2.74s	_2.82s	_{p=0.872 n=6}
_{Check Time}	_{50.35s (± 0.70%)}	_{50.43s (± 1.18%)}	_~	_49.72s	_51.13s	_{p=1.000 n=6}
_{Emit Time}	_{4.90s (± 1.73%)}	_{4.92s (± 1.58%)}	_~	_4.83s	_5.06s	_{p=0.748 n=6}
_{Total Time}	_{65.63s (± 0.64%)}	_{65.69s (± 1.00%)}	_~	_64.92s	_66.45s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,170	_1,229,171	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,285	_264,285	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,422,454k (± 0.03%)}	_{2,422,264k (± 0.01%)}	_~	_2,422,078k	_2,422,564k	_{p=0.810 n=6}
_{Parse Time}	_{6.22s (± 0.86%)}	_{6.23s (± 0.84%)}	_~	_6.16s	_6.31s	_{p=0.872 n=6}
_{Bind Time}	_{2.03s (± 1.14%)}	_{2.02s (± 0.54%)}	_~	_2.01s	_2.04s	_{p=0.374 n=6}
_{Check Time}	_{41.07s (± 0.31%)}	_{41.15s (± 0.37%)}	_~	_41.02s	_41.43s	_{p=0.810 n=6}
_{Emit Time}	_{4.09s (± 2.06%)}	_{4.17s (± 3.95%)}	_~	_4.02s	_4.39s	_{p=1.000 n=6}
_{Total Time}	_{53.43s (± 0.41%)}	_{53.58s (± 0.36%)}	_~	_53.28s	_53.80s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,237	_256,238	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,976	_104,976	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,238k (± 0.02%)}	_{428,234k (± 0.02%)}	_~	_428,126k	_428,312k	_{p=0.810 n=6}
_{Parse Time}	_{4.17s (± 0.56%)}	_{4.15s (± 0.36%)}	_~	_4.13s	_4.17s	_{p=0.506 n=6}
_{Bind Time}	_{1.61s (± 1.02%)}	_{1.61s (± 2.09%)}	_~	_1.55s	_1.64s	_{p=0.373 n=6}
_{Check Time}	_{22.25s (± 0.28%)}	_{22.20s (± 0.47%)}	_~	_22.08s	_22.33s	_{p=0.518 n=6}
_{Emit Time}	_{2.01s (± 1.12%)}	_{2.03s (± 1.26%)}	_~	_2.00s	_2.06s	_{p=0.258 n=6}
_{Total Time}	_{30.04s (± 0.14%)}	_{30.00s (± 0.38%)}	_~	_29.90s	_30.18s	_{p=0.423 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,155k (± 0.05%)}	_{370,059k (± 0.03%)}	_~	_369,967k	_370,269k	_{p=0.810 n=6}
_{Parse Time}	_{3.46s (± 0.63%)}	_{3.46s (± 0.89%)}	_~	_3.41s	_3.49s	_{p=0.871 n=6}
_{Bind Time}	_{1.91s (± 0.43%)}	_{1.93s (± 0.61%)}	_{+0.02s (+ 0.78%)}	_1.91s	_1.94s	_{p=0.048 n=6}
_{Check Time}	_{19.32s (± 0.42%)}	_{19.34s (± 0.29%)}	_~	_19.30s	_19.45s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.69s (± 0.35%)}	_{24.73s (± 0.16%)}	_~	_24.67s	_24.78s	_{p=0.471 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,990,977	_2,990,977	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,029,155	_1,029,155	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,116,199k (± 0.00%)}	_{3,116,160k (± 0.00%)}	_~	_3,116,054k	_3,116,250k	_{p=0.810 n=6}
_{Parse Time}	_{13.78s (± 0.36%)}	_{13.77s (± 0.33%)}	_~	_13.74s	_13.86s	_{p=0.374 n=6}
_{Bind Time}	_{4.29s (± 2.00%)}	_{4.26s (± 0.41%)}	_~	_4.23s	_4.28s	_{p=0.868 n=6}
_{Check Time}	_{78.72s (± 0.31%)}	_{78.57s (± 0.31%)}	_~	_78.28s	_78.95s	_{p=0.296 n=6}
_{Emit Time}	_{20.38s (± 0.29%)}	_{20.43s (± 0.39%)}	_~	_20.34s	_20.58s	_{p=0.422 n=6}
_{Total Time}	_{117.18s (± 0.25%)}	_{117.04s (± 0.16%)}	_~	_116.88s	_117.36s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_268,265	_268,265	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,187	_109,187	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{413,161k (± 0.04%)}	_{413,076k (± 0.01%)}	_~	_412,997k	_413,180k	_{p=0.471 n=6}
_{Parse Time}	_{3.82s (± 0.27%)}	_{3.82s (± 0.33%)}	_~	_3.81s	_3.84s	_{p=0.560 n=6}
_{Bind Time}	_{1.71s (± 0.80%)}	_{1.71s (± 0.74%)}	_~	_1.70s	_1.73s	_{p=0.510 n=6}
_{Check Time}	_{16.92s (± 0.61%)}	_{16.85s (± 0.36%)}	_~	_16.78s	_16.95s	_{p=0.198 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.45s (± 0.44%)}	_{22.38s (± 0.32%)}	_~	_22.31s	_22.49s	_{p=0.261 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,543	_538,543	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,469	_176,469	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,365k (± 0.01%)}	_{481,339k (± 0.01%)}	_~	_481,279k	_481,408k	_{p=0.471 n=6}
_{Parse Time}	_{3.41s (± 0.34%)}	_{3.41s (± 0.43%)}	_~	_3.39s	_3.43s	_{p=0.680 n=6}
_{Bind Time}	_{1.26s (± 0.67%)}	_{1.26s (± 0.41%)}	_~	_1.25s	_1.26s	_{p=0.533 n=6}
_{Check Time}	_{17.98s (± 0.27%)}	_{18.04s (± 0.47%)}	_~	_17.96s	_18.16s	_{p=0.376 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.64s (± 0.24%)}	_{22.71s (± 0.34%)}	_~	_22.62s	_22.80s	_{p=0.370 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-02T21:34:54Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/56105/merge:

Everything looks good!

typescript-bot assigned RyanCavanaugh Oct 13, 2023

typescript-bot added Author: Team For Backlog Bug PRs that fix a backlog bug labels Oct 13, 2023

sandersn approved these changes Nov 3, 2023

View reviewed changes

Use contextual type to determine 'this' when determining member visib…

c8229e6

…ility Fixes microsoft#56094

RyanCavanaugh force-pushed the fix56094 branch from 215a87a to c8229e6 Compare August 2, 2024 19:54

Fix comment

72b3284

Update baseline

9be08e5

RyanCavanaugh added 2 commits August 2, 2024 14:40

Merge branch 'main' into fix56094

932b6e8

More baselines?

67f8a5a

RyanCavanaugh merged commit aafdfe5 into microsoft:main Aug 2, 2024
32 checks passed

RyanCavanaugh deleted the fix56094 branch August 2, 2024 22:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use contextual type to determine 'this' when determining member visibility #56105

Use contextual type to determine 'this' when determining member visibility #56105

RyanCavanaugh commented Oct 13, 2023

jakebailey commented Oct 13, 2023

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023

typescript-bot commented Oct 13, 2023

Compiler

tsserver

Startup

typescript-bot commented Oct 14, 2023

typescript-bot commented Oct 14, 2023

sandersn Nov 3, 2023

sandersn commented Dec 4, 2023

RyanCavanaugh commented Aug 2, 2024

typescript-bot commented Aug 2, 2024 •

edited

Loading

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

tsc

typescript-bot commented Aug 2, 2024

	// 3. This 'this' parameter of a contextual type
	// 3. The 'this' parameter of a contextual type

Use contextual type to determine 'this' when determining member visibility #56105

Use contextual type to determine 'this' when determining member visibility #56105

Conversation

RyanCavanaugh commented Oct 13, 2023

jakebailey commented Oct 13, 2023

typescript-bot commented Oct 13, 2023 • edited Loading

typescript-bot commented Oct 13, 2023 • edited Loading

typescript-bot commented Oct 13, 2023 • edited Loading

typescript-bot commented Oct 13, 2023 • edited Loading

typescript-bot commented Oct 13, 2023 • edited Loading

typescript-bot commented Oct 13, 2023 • edited Loading

typescript-bot commented Oct 13, 2023

typescript-bot commented Oct 13, 2023

Compiler

tsserver

Startup

typescript-bot commented Oct 14, 2023

typescript-bot commented Oct 14, 2023

sandersn Nov 3, 2023

Choose a reason for hiding this comment

sandersn commented Dec 4, 2023

RyanCavanaugh commented Aug 2, 2024

typescript-bot commented Aug 2, 2024 • edited Loading

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

tsc

typescript-bot commented Aug 2, 2024

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Oct 13, 2023 •

edited

Loading

typescript-bot commented Aug 2, 2024 •

edited

Loading