Disallow numeric literals with negative numbers #55268

Andarist · 2023-08-04T16:49:02Z

This would prevent issues like this one (that was fixed by #55065 ).

Since a negative number is not a numeric literal, I think it's worth disallowing such AST nodes from being created.

typescript-bot · 2023-08-04T16:49:06Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Andarist · 2023-08-04T16:54:39Z

src/compiler/transformers/generators.ts

@@ -2528,7 +2528,7 @@ export function transformGenerators(context: TransformationContext): (x: SourceF
                labelExpressions = [];
            }

-            const expression = factory.createNumericLiteral(-1);
+            const expression = factory.createNumericLiteral(Infinity);


This shows how createNumericLiteral is still a somewhat weird thing. Infinity is allowed because parsed numbers are "normalized" to text here:

TypeScript/src/compiler/scanner.ts

Lines 1765 to 1773 in 83f3abd

else { // not a bigint, so can convert to number in simplified form

// Number() may not support 0b or 0o, so use parseInt() instead

const numericValue = tokenFlags & TokenFlags.BinarySpecifier

? parseInt(tokenValue.slice(2), 2) // skip "0b"

: tokenFlags & TokenFlags.OctalSpecifier

? parseInt(tokenValue.slice(2), 8) // skip "0o"

: +tokenValue;

tokenValue = "" + numericValue;

return SyntaxKind.NumericLiteral;

So a sufficiently long number in the input can be stringified to Infinity 🤷‍♂️ I find it weird an there is an issue about it that is labeled as a bug. While it doesn't mention Infinity case the issue there is basically related to the same "normalization".

This issue is certainly fixable but I'm not 100% sure if you'd really want to fix it.

Don't change this to Infinity since we really should consider that invalid as well. I'd just use a large value that we're unlikely to actually hit in a generator, something like 2 ** 32 - 1 (max uint32). The only reason it's set to -1 is to make it obvious something went wrong in tests.

Don't change this to Infinity

Ye, I committed it this way specifically to add this PR comment 😅

since we really should consider that invalid as well.

Strong agree, I had versions of this work that forbid this as well but decided to roll them back and only start the conversation about this for now. I'm open to following up with further changes but it seems that the mentioned "normalization" of parsed numeric literals is relied upon in a couple of places. They can be adjusted but I'm not sure if this is something you'd like to do. In a way, it would be easiest to just drop this whole normalization altogether and just cast parsed text to string in those other places (to produce correct resolved property names etc).

I'd just use a large value that we're unlikely to actually hit in a generator, something like 2 ** 32 - 1 (max uint32).

pushed out a change with Number.MAX_SAFE_INTEGER

src/compiler/transformers/declarations.ts

rbuckton · 2023-08-04T19:49:01Z

src/compiler/transformers/generators.ts

@@ -2528,7 +2528,7 @@ export function transformGenerators(context: TransformationContext): (x: SourceF
                labelExpressions = [];
            }

-            const expression = factory.createNumericLiteral(-1);
+            const expression = factory.createNumericLiteral(Infinity);


Don't change this to Infinity since we really should consider that invalid as well. I'd just use a large value that we're unlikely to actually hit in a generator, something like 2 ** 32 - 1 (max uint32). The only reason it's set to -1 is to make it obvious something went wrong in tests.

rbuckton · 2023-08-04T19:49:42Z

tests/baselines/reference/binaryIntegerLiteral.types

@@ -15,7 +15,7 @@ var bin3 = 0B1111111111111111111111111111111111111111111111110100101010000001011

 var bin4 = 0B111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111101001010100000010111110001111111111;
 >bin4 : number
->0B111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111101001010100000010111110001111111111 : Infinity
+>0B111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111101001010100000010111110001111111111 : number


I really hope no one is relying on this.

rbuckton · 2023-08-04T19:50:14Z

@typescript-bot perf test
@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2023-08-04T19:50:16Z

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at 167a0ee. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-04T19:50:16Z

Heya @rbuckton, I've started to run the extended test suite on this PR at 167a0ee. You can monitor the build here.

typescript-bot · 2023-08-04T19:50:16Z

Heya @rbuckton, I've started to run the perf test suite on this PR at 167a0ee. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-04T19:50:16Z

Heya @rbuckton, I've started to run the diff-based user code test suite on this PR at 167a0ee. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-04T20:17:57Z

@rbuckton Here are the results of running the user test suite comparing main and refs/pull/55268/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55268/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-08-04T20:46:59Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..55268

_Metric	_main	₅₅₂₆₈	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{368,806k (± 0.01%)}	_{368,819k (± 0.01%)}	_~	_368,784k	_368,845k	_{p=0.575 n=6}
_{Parse Time}	_{3.39s (± 0.68%)}	_{3.42s (± 0.73%)}	_~	_3.37s	_3.44s	_{p=0.122 n=6}
_{Bind Time}	_{1.12s (± 1.04%)}	_{1.12s (± 0.36%)}	_~	_1.12s	_1.13s	_{p=0.858 n=6}
_{Check Time}	_{9.01s (± 0.59%)}	_{9.01s (± 0.19%)}	_~	_8.99s	_9.04s	_{p=1.000 n=6}
_{Emit Time}	_{7.54s (± 0.82%)}	_{7.55s (± 0.43%)}	_~	_7.50s	_7.59s	_{p=0.628 n=6}
_{Total Time}	_{21.05s (± 0.51%)}	_{21.10s (± 0.22%)}	_~	_21.04s	_21.15s	_{p=0.230 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,981k (± 1.18%)}	_{192,069k (± 0.01%)}	_~	_192,042k	_192,103k	_{p=0.689 n=6}
_{Parse Time}	_{1.51s (± 0.91%)}	_{1.51s (± 0.34%)}	_~	_1.50s	_1.51s	_{p=0.794 n=6}
_{Bind Time}	_{0.78s (± 0.71%)}	_{0.77s (± 0.67%)}	_~	_0.77s	_0.78s	_{p=0.640 n=6}
_{Check Time}	_{9.53s (± 0.57%)}	_{9.54s (± 0.42%)}	_~	_9.47s	_9.57s	_{p=0.872 n=6}
_{Emit Time}	_{2.74s (± 0.94%)}	_{2.75s (± 0.87%)}	_~	_2.71s	_2.77s	_{p=0.466 n=6}
_{Total Time}	_{14.55s (± 0.58%)}	_{14.57s (± 0.25%)}	_~	_14.53s	_14.62s	_{p=0.573 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{347,747k (± 0.01%)}	_{347,787k (± 0.01%)}	_{+39k (+ 0.01%)}	_347,743k	_347,870k	_{p=0.045 n=6}
_{Parse Time}	_{2.62s (± 0.72%)}	_{2.62s (± 0.52%)}	_~	_2.60s	_2.64s	_{p=0.805 n=6}
_{Bind Time}	_{1.01s (± 0.80%)}	_{1.01s (± 0.82%)}	_~	_1.00s	_1.02s	_{p=0.718 n=6}
_{Check Time}	_{7.33s (± 0.78%)}	_{7.38s (± 0.28%)}	_~	_7.36s	_7.42s	_{p=0.126 n=6}
_{Emit Time}	_{4.25s (± 1.08%)}	_{4.26s (± 0.93%)}	_~	_4.21s	_4.32s	_{p=0.687 n=6}
_{Total Time}	_{15.21s (± 0.28%)}	_{15.28s (± 0.43%)}	_{+0.07s (+ 0.46%)}	_15.17s	_15.37s	_{p=0.045 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{301,802k (± 0.00%)}	_{301,797k (± 0.01%)}	_~	_301,749k	_301,824k	_{p=0.936 n=6}
_{Parse Time}	_{2.08s (± 1.11%)}	_{2.10s (± 0.98%)}	_~	_2.07s	_2.12s	_{p=0.224 n=6}
_{Bind Time}	_{1.12s (± 0.88%)}	_{1.13s (± 0.74%)}	_~	_1.11s	_1.13s	_{p=0.588 n=6}
_{Check Time}	_{6.66s (± 0.65%)}	_{6.70s (± 0.32%)}	_~	_6.67s	_6.73s	_{p=0.107 n=6}
_{Emit Time}	_{3.86s (± 0.46%)}	_{3.88s (± 1.17%)}	_~	_3.82s	_3.95s	_{p=0.568 n=6}
_{Total Time}	_{13.73s (± 0.41%)}	_{13.80s (± 0.18%)}	_{+0.08s (+ 0.56%)}	_13.78s	_13.84s	_{p=0.007 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,642k (± 0.01%)}	_{482,593k (± 0.01%)}	_~	_482,565k	_482,637k	_{p=0.149 n=6}
_{Parse Time}	_{3.09s (± 2.22%)}	_{3.07s (± 2.95%)}	_~	_2.95s	_3.14s	_{p=0.870 n=6}
_{Bind Time}	_{0.93s (± 3.78%)}	_{0.95s (± 5.99%)}	_~	_0.91s	_1.03s	_{p=0.558 n=6}
_{Check Time}	_{17.41s (± 0.56%)}	_{17.46s (± 0.74%)}	_~	_17.32s	_17.60s	_{p=0.575 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.44s (± 0.40%)}	_{21.49s (± 0.64%)}	_~	_21.33s	_21.66s	_{p=0.471 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,841k (± 0.02%)}	_{563,833k (± 0.02%)}	_~	_563,728k	_564,038k	_{p=0.810 n=6}
_{Parse Time}	_{3.85s (± 0.91%)}	_{3.84s (± 0.73%)}	_~	_3.81s	_3.89s	_{p=0.627 n=6}
_{Bind Time}	_{1.63s (± 0.51%)}	_{1.64s (± 0.92%)}	_~	_1.62s	_1.66s	_{p=0.162 n=6}
_{Check Time}	_{2.79s (± 0.87%)}	_{2.80s (± 0.66%)}	_~	_2.78s	_2.82s	_{p=0.222 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.35s (± 0.70%)}	_{8.37s (± 0.48%)}	_~	_8.33s	_8.43s	_{p=0.936 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{368,222k (± 0.00%)}	_{368,231k (± 0.00%)}	_~	_368,216k	_368,258k	_{p=0.332 n=6}
_{Parse Time}	_{3.55s (± 0.48%)}	_{3.57s (± 0.55%)}	_~	_3.54s	_3.59s	_{p=0.222 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.88%)}	_~	_1.17s	_1.20s	_{p=0.794 n=6}
_{Check Time}	_{9.78s (± 0.47%)}	_{9.77s (± 0.42%)}	_~	_9.74s	_9.84s	_{p=1.000 n=6}
_{Emit Time}	_{7.97s (± 0.83%)}	_{8.00s (± 0.83%)}	_~	_7.93s	_8.10s	_{p=0.467 n=6}
_{Total Time}	_{22.48s (± 0.25%)}	_{22.52s (± 0.45%)}	_~	_22.43s	_22.71s	_{p=0.575 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,819k (± 0.03%)}	_{193,855k (± 0.02%)}	_~	_193,803k	_193,935k	_{p=0.230 n=6}
_{Parse Time}	_{1.59s (± 0.65%)}	_{1.60s (± 0.65%)}	_~	_1.58s	_1.61s	_{p=0.134 n=6}
_{Bind Time}	_{0.82s (± 1.25%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.663 n=6}
_{Check Time}	_{10.21s (± 0.45%)}	_{10.24s (± 0.62%)}	_~	_10.18s	_10.35s	_{p=0.422 n=6}
_{Emit Time}	_{2.99s (± 0.58%)}	_{3.00s (± 1.45%)}	_~	_2.96s	_3.06s	_{p=1.000 n=6}
_{Total Time}	_{15.61s (± 0.20%)}	_{15.66s (± 0.61%)}	_~	_15.58s	_15.85s	_{p=0.226 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,077k (± 0.01%)}	_{347,071k (± 0.00%)}	_~	_347,058k	_347,086k	_{p=0.810 n=6}
_{Parse Time}	_{2.77s (± 0.29%)}	_{2.77s (± 0.40%)}	_~	_2.76s	_2.79s	_{p=0.448 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.08s (± 0.38%)}	_~	_1.07s	_1.08s	_{p=0.112 n=6}
_{Check Time}	_{8.04s (± 0.47%)}	_{8.07s (± 0.69%)}	_~	_7.99s	_8.15s	_{p=0.376 n=6}
_{Emit Time}	_{4.47s (± 0.82%)}	_{4.47s (± 0.44%)}	_~	_4.45s	_4.50s	_{p=0.934 n=6}
_{Total Time}	_{16.36s (± 0.26%)}	_{16.38s (± 0.48%)}	_~	_16.30s	_16.50s	_{p=0.872 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,129k (± 0.01%)}	_{301,135k (± 0.01%)}	_~	_301,087k	_301,156k	_{p=0.575 n=6}
_{Parse Time}	_{2.20s (± 0.67%)}	_{2.20s (± 0.50%)}	_~	_2.19s	_2.22s	_{p=0.803 n=6}
_{Bind Time}	_{1.22s (± 1.24%)}	_{1.20s (± 1.23%)}	_~	_1.18s	_1.22s	_{p=0.073 n=6}
_{Check Time}	_{7.37s (± 0.46%)}	_{7.37s (± 0.30%)}	_~	_7.34s	_7.40s	_{p=1.000 n=6}
_{Emit Time}	_{4.32s (± 1.01%)}	_{4.34s (± 0.83%)}	_~	_4.30s	_4.40s	_{p=0.630 n=6}
_{Total Time}	_{15.11s (± 0.34%)}	_{15.10s (± 0.33%)}	_~	_15.04s	_15.19s	_{p=0.809 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,865k (± 0.00%)}	_{481,905k (± 0.02%)}	_~	_481,832k	_482,069k	_{p=0.520 n=6}
_{Parse Time}	_{3.27s (± 0.57%)}	_{3.25s (± 0.54%)}	_~	_3.23s	_3.28s	_{p=0.331 n=6}
_{Bind Time}	_{0.95s (± 1.15%)}	_{0.95s (± 0.57%)}	_~	_0.95s	_0.96s	_{p=0.227 n=6}
_{Check Time}	_{18.48s (± 0.99%)}	_{18.48s (± 0.33%)}	_~	_18.39s	_18.55s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.70s (± 0.92%)}	_{22.69s (± 0.30%)}	_~	_22.60s	_22.78s	_{p=0.470 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,502k (± 0.01%)}	_{561,389k (± 0.02%)}	_~	_561,287k	_561,627k	_{p=0.066 n=6}
_{Parse Time}	_{4.01s (± 0.35%)}	_{4.01s (± 0.41%)}	_~	_3.99s	_4.04s	_{p=0.622 n=6}
_{Bind Time}	_{1.74s (± 5.42%)}	_{1.71s (± 6.01%)}	_~	_1.57s	_1.81s	_{p=0.748 n=6}
_{Check Time}	_{3.06s (± 3.08%)}	_{3.08s (± 3.17%)}	_~	_3.00s	_3.26s	_{p=0.422 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.90s (± 0.50%)}	_{8.91s (± 0.56%)}	_~	_8.85s	_8.97s	_{p=0.571 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{362,161k (± 0.01%)}	_{362,144k (± 0.01%)}	_~	_362,074k	_362,218k	_{p=0.575 n=6}
_{Parse Time}	_{3.72s (± 0.33%)}	_{3.73s (± 0.62%)}	_~	_3.71s	_3.77s	_{p=0.459 n=6}
_{Bind Time}	_{1.22s (± 0.80%)}	_{1.22s (± 0.68%)}	_~	_1.22s	_1.24s	_{p=0.445 n=6}
_{Check Time}	_{10.18s (± 0.35%)}	_{10.21s (± 0.60%)}	_~	_10.15s	_10.29s	_{p=0.748 n=6}
_{Emit Time}	_{8.31s (± 0.45%)}	_{8.33s (± 0.73%)}	_~	_8.27s	_8.40s	_{p=0.747 n=6}
_{Total Time}	_{23.44s (± 0.17%)}	_{23.49s (± 0.47%)}	_~	_23.36s	_23.63s	_{p=0.630 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{189,118k (± 0.01%)}	_{189,113k (± 0.01%)}	_~	_189,087k	_189,133k	_{p=0.810 n=6}
_{Parse Time}	_{1.61s (± 0.47%)}	_{1.61s (± 0.51%)}	_~	_1.60s	_1.62s	_{p=0.306 n=6}
_{Bind Time}	_{0.85s (± 0.96%)}	_{0.85s (± 0.48%)}	_~	_0.84s	_0.85s	_{p=0.584 n=6}
_{Check Time}	_{10.36s (± 0.61%)}	_{10.40s (± 0.37%)}	_~	_10.36s	_10.47s	_{p=0.228 n=6}
_{Emit Time}	_{3.12s (± 0.69%)}	_{3.13s (± 0.77%)}	_~	_3.10s	_3.17s	_{p=0.370 n=6}
_{Total Time}	_{15.93s (± 0.46%)}	_{15.99s (± 0.35%)}	_~	_15.93s	_16.09s	_{p=0.170 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{342,073k (± 0.01%)}	_{342,071k (± 0.00%)}	_~	_342,058k	_342,079k	_{p=0.688 n=6}
_{Parse Time}	_{2.81s (± 0.58%)}	_{2.80s (± 0.32%)}	_~	_2.79s	_2.81s	_{p=0.357 n=6}
_{Bind Time}	_{1.10s (± 1.33%)}	_{1.10s (± 0.00%)}	_~	_1.10s	_1.10s	_{p=0.598 n=6}
_{Check Time}	_{8.38s (± 0.71%)}	_{8.37s (± 0.65%)}	_~	_8.29s	_8.46s	_{p=0.806 n=6}
_{Emit Time}	_{4.66s (± 0.81%)}	_{4.71s (± 0.94%)}	_~	_4.66s	_4.78s	_{p=0.053 n=6}
_{Total Time}	_{16.95s (± 0.24%)}	_{16.98s (± 0.43%)}	_~	_16.87s	_17.06s	_{p=0.423 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{296,202k (± 0.00%)}	_{296,207k (± 0.00%)}	_~	_296,197k	_296,223k	_{p=0.687 n=6}
_{Parse Time}	_{2.42s (± 1.03%)}	_{2.43s (± 0.96%)}	_~	_2.39s	_2.46s	_{p=0.517 n=6}
_{Bind Time}	_{1.08s (± 0.95%)}	_{1.08s (± 0.48%)}	_~	_1.07s	_1.08s	_{p=0.242 n=6}
_{Check Time}	_{7.69s (± 0.59%)}	_{7.69s (± 0.40%)}	_~	_7.65s	_7.74s	_{p=0.574 n=6}
_{Emit Time}	_{4.29s (± 0.61%)}	_{4.30s (± 0.46%)}	_~	_4.28s	_4.33s	_{p=0.333 n=6}
_{Total Time}	_{15.48s (± 0.42%)}	_{15.50s (± 0.35%)}	_~	_15.43s	_15.58s	_{p=0.630 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,364k (± 0.01%)}	_{477,381k (± 0.00%)}	_~	_477,370k	_477,404k	_{p=0.378 n=6}
_{Parse Time}	_{3.31s (± 0.48%)}	_{3.30s (± 0.30%)}	_~	_3.29s	_3.31s	_{p=0.157 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{0.99s (± 0.64%)}	_~	_0.98s	_1.00s	_{p=0.201 n=6}
_{Check Time}	_{19.27s (± 0.80%)}	_{19.36s (± 0.56%)}	_~	_19.23s	_19.53s	_{p=0.297 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.58s (± 0.66%)}	_{23.65s (± 0.46%)}	_~	_23.54s	_23.81s	_{p=0.468 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,207k (± 0.00%)}	_{550,214k (± 0.01%)}	_~	_550,164k	_550,250k	_{p=0.873 n=6}
_{Parse Time}	_{4.22s (± 0.49%)}	_{4.22s (± 0.68%)}	_~	_4.19s	_4.26s	_{p=0.808 n=6}
_{Bind Time}	_{1.69s (± 0.99%)}	_{1.69s (± 1.75%)}	_~	_1.63s	_1.71s	_{p=0.505 n=6}
_{Check Time}	_{3.11s (± 0.60%)}	_{3.10s (± 0.29%)}	_~	_3.09s	_3.11s	_{p=0.114 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=0.174 n=6}
_{Total Time}	_{9.13s (± 0.44%)}	_{9.10s (± 0.38%)}	_~	_9.06s	_9.15s	_{p=0.296 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₂₆₈	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..55268

_Metric	_main	₅₅₂₆₈	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,544ms (± 0.42%)}	_{2,536ms (± 0.17%)}	_~	_2,532ms	_2,544ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{5,430ms (± 0.33%)}	_{5,401ms (± 0.64%)}	_~	_5,353ms	_5,433ms	_{p=0.336 n=6}
_{Req 3 - references}	_{343ms (± 1.19%)}	_{339ms (± 0.22%)}	_{-4ms (- 1.21%)}	_338ms	_340ms	_{p=0.011 n=6}
_{Req 4 - navto}	_{289ms (± 0.81%)}	_{289ms (± 0.36%)}	_~	_287ms	_290ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 0.94%)}	_{87ms (± 0.60%)}	_~	_86ms	_87ms	_{p=0.523 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,619ms (± 0.88%)}	_{2,623ms (± 0.53%)}	_~	_2,597ms	_2,639ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,146ms (± 0.60%)}	_{4,147ms (± 0.51%)}	_~	_4,120ms	_4,181ms	_{p=0.936 n=6}
_{Req 3 - references}	_{356ms (± 0.41%)}	_{355ms (± 0.37%)}	_~	_353ms	_357ms	_{p=0.560 n=6}
_{Req 4 - navto}	_{290ms (± 0.68%)}	_{291ms (± 0.67%)}	_~	_288ms	_293ms	_{p=0.280 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 1.37%)}	_{88ms (± 1.02%)}	_~	_87ms	_89ms	_{p=0.437 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,082ms (± 0.22%)}	_{3,087ms (± 0.37%)}	_~	_3,068ms	_3,099ms	_{p=0.375 n=6}
_{Req 2 - geterr}	_{1,562ms (± 0.96%)}	_{1,637ms (± 6.80%)}	_~	_1,540ms	_1,796ms	_{p=0.199 n=6}
_{Req 3 - references}	_{115ms (± 2.38%)}	_{113ms (± 2.13%)}	_~	_109ms	_115ms	_{p=0.195 n=6}
_{Req 4 - navto}	_{369ms (± 0.38%)}	_{373ms (± 1.26%)}	_~	_368ms	_380ms	_{p=0.124 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{383ms (± 1.80%)}	_{381ms (± 2.14%)}	_~	_371ms	_393ms	_{p=0.685 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,623ms (± 0.84%)}	_{2,605ms (± 0.50%)}	_~	_2,593ms	_2,629ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{6,074ms (± 0.48%)}	_{6,056ms (± 0.46%)}	_~	_6,034ms	_6,109ms	_{p=0.297 n=6}
_{Req 3 - references}	_{356ms (± 1.10%)}	_{356ms (± 0.81%)}	_~	_354ms	_361ms	_{p=0.932 n=6}
_{Req 4 - navto}	_{287ms (± 1.35%)}	_{287ms (± 0.78%)}	_~	_284ms	_289ms	_{p=0.746 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 3.89%)}	_{81ms (± 0.64%)}	_~	_80ms	_81ms	_{p=0.070 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,797ms (± 0.34%)}	_{2,798ms (± 0.86%)}	_~	_2,756ms	_2,820ms	_{p=0.377 n=6}
_{Req 2 - geterr}	_{4,702ms (± 0.37%)}	_{4,684ms (± 0.27%)}	_~	_4,674ms	_4,708ms	_{p=0.092 n=6}
_{Req 3 - references}	_{362ms (± 0.57%)}	_{365ms (± 0.48%)}	_~	_362ms	_367ms	_{p=0.073 n=6}
_{Req 4 - navto}	_{281ms (± 0.65%)}	_{282ms (± 1.46%)}	_~	_277ms	_287ms	_{p=0.744 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 4.12%)}	_{77ms (± 1.09%)}	_~	_75ms	_77ms	_{p=0.788 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,218ms (± 0.34%)}	_{3,226ms (± 0.28%)}	_~	_3,218ms	_3,240ms	_{p=0.072 n=6}
_{Req 2 - geterr}	_{1,694ms (± 0.47%)}	_{1,694ms (± 0.58%)}	_~	_1,683ms	_1,712ms	_{p=0.872 n=6}
_{Req 3 - references}	_{130ms (± 6.91%)}	_{131ms (± 7.91%)}	_~	_123ms	_144ms	_{p=0.625 n=6}
_{Req 4 - navto}	_{355ms (± 0.58%)}	_{354ms (± 0.56%)}	_~	_350ms	_356ms	_{p=0.460 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{405ms (± 0.96%)}	_{410ms (± 1.42%)}	_~	_399ms	_415ms	_{p=0.050 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,767ms (± 0.83%)}	_{2,767ms (± 0.28%)}	_~	_2,760ms	_2,781ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{6,240ms (± 0.38%)}	_{6,241ms (± 0.67%)}	_~	_6,169ms	_6,294ms	_{p=0.748 n=6}
_{Req 3 - references}	_{362ms (± 1.19%)}	_{362ms (± 1.10%)}	_~	_359ms	_370ms	_{p=0.809 n=6}
_{Req 4 - navto}	_{290ms (± 0.94%)}	_{290ms (± 0.48%)}	_~	_288ms	_291ms	_{p=0.681 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{105ms (± 7.75%)}	_{105ms (± 7.73%)}	_~	_91ms	_111ms	_{p=0.511 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,942ms (± 0.40%)}	_{2,932ms (± 0.32%)}	_~	_2,920ms	_2,948ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{4,589ms (± 0.35%)}	_{4,590ms (± 0.73%)}	_~	_4,560ms	_4,649ms	_{p=0.748 n=6}
_{Req 3 - references}	_{375ms (± 0.35%)}	_{376ms (± 0.40%)}	_~	_374ms	_378ms	_{p=0.511 n=6}
_{Req 4 - navto}	_{294ms (± 0.73%)}	_{294ms (± 0.96%)}	_~	_291ms	_298ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 3.56%)}	_{83ms (± 0.91%)}	_~	_82ms	_84ms	_{p=0.054 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,510ms (± 0.54%)}	_{3,501ms (± 0.51%)}	_~	_3,474ms	_3,523ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{1,813ms (± 0.43%)}	_{1,817ms (± 0.81%)}	_~	_1,801ms	_1,844ms	_{p=0.520 n=6}
_{Req 3 - references}	_{151ms (± 4.33%)}	_{143ms (± 8.49%)}	_~	_130ms	_154ms	_{p=0.134 n=6}
_{Req 4 - navto}	_{387ms (± 0.41%)}	_{387ms (± 0.16%)}	_~	_386ms	_388ms	_{p=0.799 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{423ms (± 1.58%)}	_{418ms (± 0.79%)}	_~	_414ms	_422ms	_{p=0.298 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₂₆₈	₆
_Baseline	_main	₆

Startup

Comparison Report - main..55268

_Metric	_main	₅₅₂₆₈	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.68ms (± 0.21%)}	_{142.95ms (± 0.21%)}	_{+0.27ms (+ 0.19%)}	_142.16ms	_147.22ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{222.04ms (± 0.18%)}	_{223.02ms (± 0.19%)}	_{+0.98ms (+ 0.44%)}	_221.69ms	_230.25ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.68ms (± 0.21%)}	_{224.98ms (± 0.29%)}	_{+1.31ms (+ 0.58%)}	_223.13ms	_234.92ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{206.30ms (± 0.30%)}	_{206.69ms (± 0.23%)}	_{+0.40ms (+ 0.19%)}	_205.22ms	_210.72ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₂₆₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-08-04T21:42:12Z

Hey @rbuckton, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

)" This reverts commit f0c3c3f.

…6422)

…osoft#55268)" (microsoft#56422)" This reverts commit 3333e90.

Disallow numeric literals with negative numbers

167a0ee

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 4, 2023

Andarist commented Aug 4, 2023

View reviewed changes

RyanCavanaugh assigned rbuckton Aug 4, 2023

rbuckton requested changes Aug 4, 2023

View reviewed changes

tweaks

7fc1803

rbuckton approved these changes Aug 7, 2023

View reviewed changes

rbuckton merged commit f0c3c3f into microsoft:main Aug 7, 2023

Andarist mentioned this pull request Oct 31, 2023

Infinities as number literal types #56272

Open

jakebailey added a commit to jakebailey/TypeScript that referenced this pull request Nov 15, 2023

Revert "Disallow numeric literals with negative numbers (microsoft#55268

7f0b9ae

)" This reverts commit f0c3c3f.

jakebailey mentioned this pull request Nov 15, 2023

Revert "Disallow numeric literals with negative numbers (#55268)" #56422

Merged

jakebailey added a commit that referenced this pull request Nov 15, 2023

Revert "Disallow numeric literals with negative numbers (#55268)" (#5…

3333e90

…6422)

DanielRosenwasser pushed a commit that referenced this pull request Nov 16, 2023

Revert "Disallow numeric literals with negative numbers (#55268)" (#5…

11dbc85

…6422)

DanielRosenwasser pushed a commit that referenced this pull request Nov 16, 2023

Revert "Disallow numeric literals with negative numbers (#55268)" (#5…

64b5c79

…6422)

DanielRosenwasser mentioned this pull request Nov 16, 2023

Fixes for release-5.3. #56424

Merged

Andarist added a commit to Andarist/TypeScript that referenced this pull request Nov 28, 2023

Revert "Revert "Disallow numeric literals with negative numbers (micr…

3d7c53d

…osoft#55268)" (microsoft#56422)" This reverts commit 3333e90.

Andarist mentioned this pull request Nov 28, 2023

Disallow negative numbers in create numeric literal (take 2) #56570

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow numeric literals with negative numbers #55268

Disallow numeric literals with negative numbers #55268

Andarist commented Aug 4, 2023

typescript-bot commented Aug 4, 2023

Andarist Aug 4, 2023

rbuckton Aug 4, 2023

Andarist Aug 4, 2023

rbuckton Aug 4, 2023

rbuckton Aug 4, 2023

rbuckton commented Aug 4, 2023

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Aug 4, 2023

Compiler

TSServer

Startup

typescript-bot commented Aug 4, 2023

	else { // not a bigint, so can convert to number in simplified form
	// Number() may not support 0b or 0o, so use parseInt() instead
	const numericValue = tokenFlags & TokenFlags.BinarySpecifier
	? parseInt(tokenValue.slice(2), 2) // skip "0b"
	: tokenFlags & TokenFlags.OctalSpecifier
	? parseInt(tokenValue.slice(2), 8) // skip "0o"
	: +tokenValue;
	tokenValue = "" + numericValue;
	return SyntaxKind.NumericLiteral;

Disallow numeric literals with negative numbers #55268

Disallow numeric literals with negative numbers #55268

Conversation

Andarist commented Aug 4, 2023

typescript-bot commented Aug 4, 2023

Andarist Aug 4, 2023

Choose a reason for hiding this comment

rbuckton Aug 4, 2023

Choose a reason for hiding this comment

Andarist Aug 4, 2023

Choose a reason for hiding this comment

rbuckton Aug 4, 2023

Choose a reason for hiding this comment

rbuckton Aug 4, 2023

Choose a reason for hiding this comment

rbuckton commented Aug 4, 2023

typescript-bot commented Aug 4, 2023 • edited Loading

typescript-bot commented Aug 4, 2023 • edited Loading

typescript-bot commented Aug 4, 2023 • edited Loading

typescript-bot commented Aug 4, 2023 • edited Loading

typescript-bot commented Aug 4, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Aug 4, 2023

Compiler

TSServer

Startup

typescript-bot commented Aug 4, 2023

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023 •

edited

Loading

typescript-bot commented Aug 4, 2023 •

edited

Loading