Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(52517): JSDoc Comment Template not provided when unrelated JSDoc with tag exists #54132

Merged
merged 3 commits into from
May 24, 2023
Merged

fix(52517): JSDoc Comment Template not provided when unrelated JSDoc with tag exists #54132

merged 3 commits into from
May 24, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #52517

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 4, 2023
sandersn
sandersn requested changes May 19, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need one more test without an intervening empty comment.

tests/cases/fourslash/docCommentTemplateWithMultipleJSDocAndParameters.ts Show resolved Hide resolved
@sandersn sandersn self-assigned this May 19, 2023
@sandersn sandersn requested a review from gabritto May 19, 2023 23:59
sandersn
sandersn requested changes May 22, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test case in comment 3 should not generate a template.

@a-tarasyuk a-tarasyuk requested a review from sandersn May 22, 2023 23:24
@sandersn sandersn merged commit 8db251f into microsoft:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@gabritto gabritto Awaiting requested review from gabritto

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSDoc Comment Template not provided when unrelated JSDoc with tag exists
3 participants
@a-tarasyuk @sandersn @typescript-bot