Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'var' hoisting in 'if' in SystemJS emit #54016

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix 'var' hoisting in 'if' in SystemJS emit #54016

merged 1 commit into from
Apr 25, 2023

Conversation

rbuckton
Copy link
Member

Fixes a failure to descend into top-level if statements to properly hoist var declarations.

Fixes #54015

@rbuckton rbuckton requested review from sandersn and jakebailey April 25, 2023 21:43
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 25, 2023
@rbuckton rbuckton merged commit 5ad4ac8 into main Apr 25, 2023
@rbuckton rbuckton deleted the fix-54015 branch April 25, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SystemJS transform fails to hoist top-level var inside if statement
3 participants
@rbuckton @jakebailey @typescript-bot