Exclude parameters of non-inferrable signatures from inference #53756

ahejlsberg · 2023-04-12T18:26:45Z

ahejlsberg · 2023-04-12T18:27:36Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-04-12T18:27:38Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 210023c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-12T18:27:38Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 210023c. You can monitor the build here.

typescript-bot · 2023-04-12T18:27:38Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 210023c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-12T18:27:38Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 210023c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-12T18:27:38Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 210023c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-12T18:40:29Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53756/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-12T18:43:29Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53756

_Metric	_main	₅₃₇₅₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{364,717k (± 0.01%)}	_{364,716k (± 0.01%)}	_~	_364,686k	_364,739k	_{p=0.936 n=6}
_{Parse Time}	_{3.55s (± 1.00%)}	_{3.54s (± 0.99%)}	_~	_3.50s	_3.60s	_{p=0.466 n=6}
_{Bind Time}	_{1.18s (± 1.13%)}	_{1.18s (± 0.83%)}	_~	_1.17s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.53s (± 0.67%)}	_{9.53s (± 0.25%)}	_~	_9.50s	_9.56s	_{p=0.630 n=6}
_{Emit Time}	_{7.99s (± 0.64%)}	_{7.96s (± 0.39%)}	_~	_7.91s	_7.99s	_{p=0.373 n=6}
_{Total Time}	_{22.25s (± 0.51%)}	_{22.20s (± 0.33%)}	_~	_22.13s	_22.33s	_{p=0.470 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,527k (± 0.03%)}	_{192,527k (± 0.02%)}	_~	_192,474k	_192,590k	_{p=0.689 n=6}
_{Parse Time}	_{1.59s (± 0.95%)}	_{1.58s (± 1.33%)}	_~	_1.55s	_1.60s	_{p=0.324 n=6}
_{Bind Time}	_{0.83s (± 0.99%)}	_{0.82s (± 1.09%)}	_~	_0.81s	_0.83s	_{p=0.270 n=6}
_{Check Time}	_{10.36s (± 0.72%)}	_{10.33s (± 0.61%)}	_~	_10.25s	_10.42s	_{p=0.335 n=6}
_{Emit Time}	_{3.02s (± 1.18%)}	_{3.01s (± 1.08%)}	_~	_2.97s	_3.06s	_{p=0.935 n=6}
_{Total Time}	_{15.80s (± 0.69%)}	_{15.74s (± 0.58%)}	_~	_15.63s	_15.88s	_{p=0.469 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,788k (± 0.00%)}	_{345,769k (± 0.00%)}	_{-19k (- 0.01%)}	_345,760k	_345,790k	_{p=0.030 n=6}
_{Parse Time}	_{2.72s (± 0.60%)}	_{2.72s (± 0.92%)}	_~	_2.70s	_2.77s	_{p=0.745 n=6}
_{Bind Time}	_{1.08s (± 0.48%)}	_{1.09s (± 0.37%)}	_~	_1.08s	_1.09s	_{p=0.112 n=6}
_{Check Time}	_{7.82s (± 0.54%)}	_{7.82s (± 0.53%)}	_~	_7.76s	_7.89s	_{p=0.686 n=6}
_{Emit Time}	_{4.50s (± 0.76%)}	_{4.45s (± 0.77%)}	_{-0.05s (- 1.07%)}	_4.41s	_4.51s	_{p=0.043 n=6}
_{Total Time}	_{16.13s (± 0.44%)}	_{16.08s (± 0.55%)}	_~	_16.02s	_16.26s	_{p=0.260 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,053k (± 0.01%)}	_{300,049k (± 0.00%)}	_~	_300,033k	_300,069k	_{p=0.471 n=6}
_{Parse Time}	_{2.16s (± 0.35%)}	_{2.17s (± 0.68%)}	_~	_2.15s	_2.19s	_{p=0.241 n=6}
_{Bind Time}	_{1.24s (± 0.88%)}	_{1.24s (± 0.68%)}	_~	_1.23s	_1.25s	_{p=0.315 n=6}
_{Check Time}	_{7.22s (± 0.62%)}	_{7.25s (± 0.43%)}	_~	_7.21s	_7.29s	_{p=0.571 n=6}
_{Emit Time}	_{4.33s (± 0.66%)}	_{4.33s (± 1.43%)}	_~	_4.26s	_4.41s	_{p=0.936 n=6}
_{Total Time}	_{14.96s (± 0.37%)}	_{14.98s (± 0.59%)}	_~	_14.89s	_15.11s	_{p=0.748 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,490k (± 0.01%)}	_{479,542k (± 0.01%)}	_~	_479,509k	_479,636k	_{p=0.521 n=6}
_{Parse Time}	_{3.24s (± 0.23%)}	_{3.24s (± 0.39%)}	_~	_3.22s	_3.25s	_{p=0.676 n=6}
_{Bind Time}	_{0.96s (± 0.57%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.640 n=6}
_{Check Time}	_{18.03s (± 0.86%)}	_{18.02s (± 0.78%)}	_~	_17.86s	_18.28s	_{p=0.747 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.22s (± 0.73%)}	_{22.22s (± 0.68%)}	_~	_22.04s	_22.49s	_{p=0.746 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{559,769k (± 0.02%)}	_{559,727k (± 0.02%)}	_~	_559,585k	_559,970k	_{p=0.298 n=6}
_{Parse Time}	_{3.98s (± 0.30%)}	_{3.99s (± 0.52%)}	_~	_3.97s	_4.03s	_{p=0.465 n=6}
_{Bind Time}	_{1.75s (± 0.56%)}	_{1.75s (± 0.60%)}	_~	_1.73s	_1.76s	_{p=0.547 n=6}
_{Check Time}	_{3.06s (± 0.40%)}	_{3.06s (± 0.34%)}	_~	_3.05s	_3.08s	_{p=0.103 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.10s (± 5.34%)}	_~	_0.09s	_0.10s	_{p=0.311 n=6}
_{Total Time}	_{8.88s (± 0.09%)}	_{8.90s (± 0.23%)}	_~	_8.87s	_8.92s	_{p=0.220 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₇₅₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-04-12T20:17:26Z

Hey @ahejlsberg, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

typescript-bot · 2023-04-12T20:21:33Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53756/merge:

Everything looks good!

jakebailey · 2023-04-12T20:22:09Z

@typescript-bot run dt

npm timeout :(

typescript-bot · 2023-04-12T20:22:12Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 210023c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-12T22:08:39Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

alii · 2023-04-13T13:36:20Z

Wow thank you! This was resolved so quickly 😄 I seem to remember there being a way to test a PR in the playground? How can I do that?

@typescript-bot playground please 🤓

jakebailey · 2023-04-13T16:12:42Z

@typescript-bot pack this

typescript-bot · 2023-04-13T16:13:07Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 210023c. You can monitor the build here.

typescript-bot · 2023-04-13T16:14:51Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/152324/artifacts?artifactName=tgz&fileId=DD92FCB4F54911D57E16FB994EC6C39E58BB9C33BF4A01F647ECFC8CA2D6905202&fileName=/typescript-5.1.0-insiders.20230413.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

ahejlsberg · 2023-04-14T16:58:45Z

@typescript-bot run dt

typescript-bot · 2023-04-14T16:58:48Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 210023c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-14T18:54:22Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

ahejlsberg added 2 commits April 12, 2023 11:22

Exclude parameters of non-inferrable signatures from inference

deb32d8

Add regression test

210023c

typescript-bot assigned ahejlsberg Apr 12, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Apr 12, 2023

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh April 12, 2023 20:10

jakebailey approved these changes Apr 14, 2023

View reviewed changes

RyanCavanaugh approved these changes Apr 14, 2023

View reviewed changes

ahejlsberg merged commit e49db97 into main Apr 14, 2023

ahejlsberg deleted the fix53748 branch April 14, 2023 19:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude parameters of non-inferrable signatures from inference #53756

Exclude parameters of non-inferrable signatures from inference #53756

ahejlsberg commented Apr 12, 2023

ahejlsberg commented Apr 12, 2023

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023

typescript-bot commented Apr 12, 2023

typescript-bot commented Apr 12, 2023

typescript-bot commented Apr 12, 2023

jakebailey commented Apr 12, 2023

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023

alii commented Apr 13, 2023

jakebailey commented Apr 13, 2023

typescript-bot commented Apr 13, 2023 •

edited

Loading

typescript-bot commented Apr 13, 2023 •

edited

Loading

ahejlsberg commented Apr 14, 2023

typescript-bot commented Apr 14, 2023 •

edited

Loading

typescript-bot commented Apr 14, 2023

Exclude parameters of non-inferrable signatures from inference #53756

Exclude parameters of non-inferrable signatures from inference #53756

Conversation

ahejlsberg commented Apr 12, 2023

ahejlsberg commented Apr 12, 2023

typescript-bot commented Apr 12, 2023 • edited Loading

typescript-bot commented Apr 12, 2023 • edited Loading

typescript-bot commented Apr 12, 2023 • edited Loading

typescript-bot commented Apr 12, 2023 • edited Loading

typescript-bot commented Apr 12, 2023 • edited Loading

typescript-bot commented Apr 12, 2023

typescript-bot commented Apr 12, 2023

typescript-bot commented Apr 12, 2023

typescript-bot commented Apr 12, 2023

jakebailey commented Apr 12, 2023

typescript-bot commented Apr 12, 2023 • edited Loading

typescript-bot commented Apr 12, 2023

alii commented Apr 13, 2023

jakebailey commented Apr 13, 2023

typescript-bot commented Apr 13, 2023 • edited Loading

typescript-bot commented Apr 13, 2023 • edited Loading

ahejlsberg commented Apr 14, 2023

typescript-bot commented Apr 14, 2023 • edited Loading

typescript-bot commented Apr 14, 2023

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 12, 2023 •

edited

Loading

typescript-bot commented Apr 13, 2023 •

edited

Loading

typescript-bot commented Apr 13, 2023 •

edited

Loading

typescript-bot commented Apr 14, 2023 •

edited

Loading