Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom GHA report for package size #53241

Merged
merged 21 commits into from
Mar 14, 2023
Merged

Add custom GHA report for package size #53241

merged 21 commits into from
Mar 14, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Mar 14, 2023 •
edited
Loading

Fixes #53153

An example failing run which increases the package size by >10%: https://github.com/microsoft/TypeScript/actions/runs/4412386078#summary-11978708710

image

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 14, 2023
@jakebailey jakebailey marked this pull request as ready for review March 14, 2023 05:05
@jakebailey jakebailey mentioned this pull request Mar 14, 2023
Merged
sandersn
sandersn approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's going to work but ci.yml is lot easier to read now.

scripts/checkPackageSize.mjs Outdated Show resolved Hide resolved
scripts/checkPackageSize.mjs Outdated Show resolved Hide resolved
@jakebailey jakebailey merged commit edc343d into microsoft:main Mar 14, 2023
@jakebailey jakebailey deleted the package-size-report-gha branch March 14, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redo package size changes checks in CI
3 participants
@jakebailey @sandersn @typescript-bot