Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower jsdoc comment state #53065

Closed
wants to merge 1 commit into from
Closed

Lower jsdoc comment state #53065

wants to merge 1 commit into from

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Mar 2, 2023

Four frequently accessed variables are outside the closure passed to scanRange for no reason. I'm not sure this is going to help, but I want to run the perf tests on it without tying up my machine/having to get perf tests working again.

Small step toward addressing #52959

@sandersn sandersn requested a review from jakebailey March 2, 2023 18:31
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 2, 2023
@sandersn
Copy link
Member Author

sandersn commented Mar 2, 2023

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 2, 2023 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at f97c7c5. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53065
Metric main 53065 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,834k (± 0.01%) 359,768k (± 0.02%) ~ 359,711k 359,865k p=0.066 n=6
Parse Time 3.51s (± 0.42%) 3.50s (± 0.42%) ~ 3.48s 3.52s p=0.166 n=6
Bind Time 1.13s (± 1.33%) 1.12s (± 0.67%) ~ 1.11s 1.13s p=0.150 n=6
Check Time 8.66s (± 0.78%) 8.64s (± 0.42%) ~ 8.59s 8.68s p=0.418 n=6
Emit Time 7.42s (± 0.48%) 7.44s (± 0.91%) ~ 7.37s 7.55s p=0.807 n=6
Total Time 20.73s (± 0.48%) 20.70s (± 0.40%) ~ 20.62s 20.83s p=0.810 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 194,364k (± 1.18%) 191,551k (± 1.52%) ~ 189,582k 195,469k p=0.230 n=6
Parse Time 1.47s (± 0.70%) 1.47s (± 0.51%) ~ 1.46s 1.48s p=0.931 n=6
Bind Time 0.77s (± 0.67%) 0.77s (± 0.53%) ~ 0.76s 0.77s p=0.595 n=6
Check Time 9.35s (± 0.79%) 9.29s (± 0.70%) ~ 9.21s 9.39s p=0.199 n=6
Emit Time 2.73s (± 1.04%) 2.73s (± 0.76%) ~ 2.70s 2.75s p=1.000 n=6
Total Time 14.31s (± 0.56%) 14.26s (± 0.40%) ~ 14.18s 14.34s p=0.227 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,861k (± 0.02%) 343,910k (± 0.01%) ~ 343,873k 343,929k p=0.378 n=6
Parse Time 2.61s (± 1.01%) 2.64s (± 0.78%) ~ 2.61s 2.66s p=0.052 n=6
Bind Time 1.01s (± 0.63%) 1.01s (± 0.97%) ~ 1.00s 1.03s p=1.000 n=6
Check Time 6.96s (± 0.52%) 7.00s (± 0.32%) ~ 6.97s 7.04s p=0.052 n=6
Emit Time 4.21s (± 0.47%) 4.20s (± 0.61%) ~ 4.17s 4.24s p=0.462 n=6
Total Time 14.80s (± 0.37%) 14.86s (± 0.29%) ~ 14.79s 14.91s p=0.107 n=6
TFS - node (v18.10.0, x64)
Memory used 299,897k (± 0.01%) 299,890k (± 0.01%) ~ 299,850k 299,917k p=0.689 n=6
Parse Time 2.04s (± 0.96%) 2.03s (± 0.58%) ~ 2.01s 2.04s p=0.252 n=6
Bind Time 1.14s (± 0.71%) 1.14s (± 0.72%) ~ 1.13s 1.15s p=0.177 n=6
Check Time 6.49s (± 0.50%) 6.49s (± 0.49%) ~ 6.44s 6.53s p=1.000 n=6
Emit Time 3.85s (± 0.61%) 3.88s (± 1.11%) ~ 3.82s 3.93s p=0.333 n=6
Total Time 13.52s (± 0.16%) 13.54s (± 0.22%) ~ 13.50s 13.57s p=0.415 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,442k (± 0.00%) 476,463k (± 0.00%) +22k (+ 0.00%) 476,449k 476,487k p=0.030 n=6
Parse Time 3.10s (± 0.60%) 3.13s (± 0.79%) ~ 3.10s 3.17s p=0.126 n=6
Bind Time 0.91s (± 0.57%) 0.92s (± 1.91%) ~ 0.90s 0.95s p=0.242 n=6
Check Time 17.05s (± 0.19%) 17.07s (± 0.62%) ~ 16.97s 17.23s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.07s (± 0.20%) 21.12s (± 0.52%) ~ 21.00s 21.28s p=0.688 n=6
xstate - node (v18.10.0, x64)
Memory used 548,828k (± 0.02%) 548,869k (± 0.02%) ~ 548,737k 548,997k p=0.471 n=6
Parse Time 4.07s (± 0.45%) 4.06s (± 0.76%) ~ 4.01s 4.10s p=0.519 n=6
Bind Time 1.67s (± 1.05%) 1.67s (± 1.29%) ~ 1.64s 1.70s p=0.627 n=6
Check Time 2.78s (± 0.49%) 2.75s (± 0.44%) -0.02s (- 0.84%) 2.74s 2.77s p=0.018 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.61s (± 0.39%) 8.57s (± 0.59%) ~ 8.49s 8.63s p=0.198 n=6
Angular - node (v16.17.1, x64)
Memory used 359,116k (± 0.01%) 359,125k (± 0.01%) ~ 359,106k 359,155k p=0.378 n=6
Parse Time 3.72s (± 0.29%) 3.71s (± 0.37%) ~ 3.69s 3.73s p=0.084 n=6
Bind Time 1.19s (± 0.43%) 1.19s (± 0.92%) ~ 1.17s 1.20s p=0.784 n=6
Check Time 9.47s (± 0.33%) 9.41s (± 0.44%) -0.06s (- 0.63%) 9.36s 9.48s p=0.029 n=6
Emit Time 7.90s (± 0.57%) 7.88s (± 0.43%) ~ 7.84s 7.92s p=0.413 n=6
Total Time 22.29s (± 0.18%) 22.19s (± 0.23%) -0.10s (- 0.43%) 22.13s 22.27s p=0.013 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,310k (± 0.03%) 191,858k (± 0.71%) ~ 191,250k 194,655k p=1.000 n=6
Parse Time 1.56s (± 0.87%) 1.56s (± 0.48%) ~ 1.55s 1.57s p=0.652 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.92%) ~ 0.81s 0.83s p=0.389 n=6
Check Time 10.08s (± 0.77%) 10.09s (± 0.46%) ~ 10.00s 10.12s p=0.686 n=6
Emit Time 3.01s (± 1.48%) 2.98s (± 0.55%) ~ 2.96s 3.00s p=0.258 n=6
Total Time 15.47s (± 0.73%) 15.45s (± 0.30%) ~ 15.37s 15.50s p=1.000 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,132k (± 0.01%) 343,121k (± 0.00%) ~ 343,103k 343,136k p=0.520 n=6
Parse Time 2.80s (± 0.23%) 2.80s (± 0.47%) ~ 2.78s 2.81s p=0.498 n=6
Bind Time 1.09s (± 1.35%) 1.08s (± 0.38%) ~ 1.08s 1.09s p=0.474 n=6
Check Time 7.66s (± 0.25%) 7.67s (± 0.18%) ~ 7.65s 7.69s p=0.190 n=6
Emit Time 4.42s (± 0.60%) 4.42s (± 0.66%) ~ 4.39s 4.47s p=0.936 n=6
Total Time 15.97s (± 0.14%) 15.98s (± 0.22%) ~ 15.95s 16.04s p=0.627 n=6
TFS - node (v16.17.1, x64)
Memory used 299,258k (± 0.01%) 299,253k (± 0.00%) ~ 299,239k 299,271k p=0.630 n=6
Parse Time 2.14s (± 0.59%) 2.17s (± 0.68%) +0.03s (+ 1.32%) 2.15s 2.19s p=0.015 n=6
Bind Time 1.24s (± 0.94%) 1.25s (± 0.41%) ~ 1.24s 1.25s p=0.523 n=6
Check Time 7.17s (± 0.52%) 7.18s (± 0.59%) ~ 7.11s 7.24s p=1.000 n=6
Emit Time 4.35s (± 0.74%) 4.33s (± 0.65%) ~ 4.28s 4.36s p=0.517 n=6
Total Time 14.91s (± 0.44%) 14.93s (± 0.37%) ~ 14.87s 15.01s p=0.688 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,707k (± 0.02%) 475,683k (± 0.01%) ~ 475,645k 475,717k p=0.688 n=6
Parse Time 3.28s (± 0.40%) 3.28s (± 0.37%) ~ 3.27s 3.30s p=0.591 n=6
Bind Time 0.96s (± 0.42%) 0.96s (± 0.42%) ~ 0.96s 0.97s p=1.000 n=6
Check Time 18.02s (± 0.21%) 18.03s (± 0.40%) ~ 17.93s 18.13s p=0.809 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.26s (± 0.21%) 22.27s (± 0.33%) ~ 22.16s 22.37s p=0.687 n=6
xstate - node (v16.17.1, x64)
Memory used 546,498k (± 0.02%) 546,451k (± 0.03%) ~ 546,337k 546,697k p=0.229 n=6
Parse Time 4.26s (± 0.41%) 4.23s (± 0.35%) -0.03s (- 0.82%) 4.20s 4.24s p=0.007 n=6
Bind Time 1.77s (± 0.58%) 1.76s (± 0.75%) ~ 1.75s 1.78s p=0.553 n=6
Check Time 2.99s (± 0.58%) 2.97s (± 0.41%) ~ 2.96s 2.99s p=0.157 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 4.45%) ~ 0.09s 0.10s p=0.405 n=6
Total Time 9.11s (± 0.31%) 9.06s (± 0.38%) -0.05s (- 0.53%) 9.01s 9.10s p=0.036 n=6
Angular - node (v14.15.1, x64)
Memory used 352,863k (± 0.01%) 352,889k (± 0.00%) +27k (+ 0.01%) 352,861k 352,909k p=0.037 n=6
Parse Time 3.69s (± 0.24%) 3.71s (± 0.46%) ~ 3.69s 3.73s p=0.084 n=6
Bind Time 1.25s (± 0.41%) 1.24s (± 0.41%) ~ 1.24s 1.25s p=0.311 n=6
Check Time 9.73s (± 0.53%) 9.74s (± 0.62%) ~ 9.65s 9.82s p=0.936 n=6
Emit Time 8.34s (± 0.85%) 8.30s (± 0.32%) ~ 8.26s 8.33s p=0.229 n=6
Total Time 23.02s (± 0.48%) 22.99s (± 0.20%) ~ 22.93s 23.05s p=0.629 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,541k (± 0.01%) 186,590k (± 0.02%) +50k (+ 0.03%) 186,538k 186,617k p=0.024 n=6
Parse Time 1.57s (± 0.35%) 1.56s (± 0.41%) ~ 1.55s 1.57s p=0.201 n=6
Bind Time 0.84s (± 0.61%) 0.84s (± 0.75%) ~ 0.83s 0.85s p=0.386 n=6
Check Time 10.18s (± 0.58%) 10.22s (± 0.65%) ~ 10.11s 10.28s p=0.199 n=6
Emit Time 3.15s (± 0.97%) 3.15s (± 0.94%) ~ 3.10s 3.18s p=0.685 n=6
Total Time 15.74s (± 0.59%) 15.76s (± 0.61%) ~ 15.60s 15.86s p=0.574 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,130k (± 0.01%) 338,128k (± 0.01%) ~ 338,095k 338,190k p=0.936 n=6
Parse Time 2.88s (± 0.77%) 2.90s (± 0.71%) ~ 2.87s 2.92s p=0.168 n=6
Bind Time 1.11s (± 1.23%) 1.10s (± 0.47%) ~ 1.10s 1.11s p=0.794 n=6
Check Time 8.11s (± 0.33%) 8.08s (± 0.45%) ~ 8.02s 8.13s p=0.145 n=6
Emit Time 4.68s (± 0.40%) 4.68s (± 0.63%) ~ 4.64s 4.70s p=0.869 n=6
Total Time 16.76s (± 0.31%) 16.75s (± 0.34%) ~ 16.69s 16.83s p=0.807 n=6
TFS - node (v14.15.1, x64)
Memory used 294,295k (± 0.00%) 294,291k (± 0.00%) ~ 294,285k 294,302k p=0.467 n=6
Parse Time 2.37s (± 0.95%) 2.37s (± 0.58%) ~ 2.36s 2.40s p=1.000 n=6
Bind Time 1.07s (± 0.92%) 1.07s (± 0.00%) ~ 1.07s 1.07s p=1.000 n=6
Check Time 7.45s (± 0.42%) 7.47s (± 0.24%) ~ 7.45s 7.49s p=0.292 n=6
Emit Time 4.28s (± 0.48%) 4.29s (± 0.70%) ~ 4.24s 4.32s p=0.332 n=6
Total Time 15.17s (± 0.34%) 15.20s (± 0.33%) ~ 15.14s 15.26s p=0.229 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,378k (± 0.01%) 471,369k (± 0.00%) ~ 471,354k 471,380k p=0.936 n=6
Parse Time 3.45s (± 0.35%) 3.46s (± 0.92%) ~ 3.43s 3.52s p=0.743 n=6
Bind Time 1.00s (± 1.04%) 1.00s (± 0.81%) ~ 0.99s 1.01s p=0.865 n=6
Check Time 18.92s (± 0.20%) 18.96s (± 0.50%) ~ 18.82s 19.11s p=0.261 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.37s (± 0.15%) 23.42s (± 0.44%) ~ 23.27s 23.57s p=0.261 n=6
xstate - node (v14.15.1, x64)
Memory used 535,179k (± 0.01%) 535,158k (± 0.01%) ~ 535,121k 535,243k p=0.298 n=6
Parse Time 4.54s (± 1.93%) 4.52s (± 1.25%) ~ 4.46s 4.60s p=0.809 n=6
Bind Time 1.73s (± 3.83%) 1.72s (± 3.21%) ~ 1.66s 1.81s p=0.872 n=6
Check Time 3.17s (± 0.80%) 3.14s (± 0.51%) ~ 3.13s 3.17s p=0.052 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 4.45%) ~ 0.09s 0.10s p=0.405 n=6
Total Time 9.54s (± 0.37%) 9.47s (± 0.42%) -0.07s (- 0.72%) 9.42s 9.53s p=0.024 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53065 6
Baseline main 6

TSServer

Comparison Report - main..53065
Metric main 53065 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,372ms (± 0.31%) 2,378ms (± 0.92%) ~ 2,356ms 2,419ms p=1.000 n=6
Req 2 - geterr 5,315ms (± 0.76%) 5,320ms (± 1.05%) ~ 5,251ms 5,383ms p=0.688 n=6
Req 3 - references 326ms (± 0.61%) 326ms (± 0.63%) ~ 324ms 329ms p=0.869 n=6
Req 4 - navto 285ms (± 0.19%) 284ms (± 0.78%) ~ 280ms 286ms p=0.865 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 78ms (± 3.88%) 77ms (± 4.22%) ~ 71ms 80ms p=0.511 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,506ms (± 1.48%) 2,512ms (± 0.78%) ~ 2,492ms 2,545ms p=0.810 n=6
Req 2 - geterr 4,009ms (± 0.88%) 4,007ms (± 0.65%) ~ 3,970ms 4,038ms p=0.873 n=6
Req 3 - references 345ms (± 0.73%) 344ms (± 0.84%) ~ 339ms 346ms p=0.739 n=6
Req 4 - navto 292ms (± 0.77%) 293ms (± 0.48%) ~ 291ms 295ms p=0.102 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 69ms (± 2.90%) 69ms (± 2.52%) ~ 68ms 72ms p=0.720 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,159ms (± 0.42%) 3,173ms (± 0.42%) ~ 3,152ms 3,194ms p=0.170 n=6
Req 2 - geterr 1,637ms (± 0.80%) 1,635ms (± 1.05%) ~ 1,603ms 1,653ms p=0.873 n=6
Req 3 - references 105ms (± 1.00%) 105ms (± 1.47%) ~ 103ms 107ms p=0.621 n=6
Req 4 - navto 360ms (± 1.08%) 359ms (± 0.63%) ~ 356ms 362ms p=0.418 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 430ms (± 0.69%) 427ms (± 1.60%) ~ 415ms 434ms p=0.871 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,492ms (± 1.86%) 2,518ms (± 2.00%) ~ 2,466ms 2,572ms p=0.128 n=6
Req 2 - geterr 5,699ms (± 0.51%) 5,673ms (± 0.31%) ~ 5,643ms 5,691ms p=0.128 n=6
Req 3 - references 340ms (± 1.24%) 339ms (± 1.03%) ~ 335ms 345ms p=0.517 n=6
Req 4 - navto 279ms (± 0.75%) 279ms (± 0.70%) ~ 276ms 282ms p=0.462 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 86ms (± 2.94%) 87ms (± 5.17%) ~ 85ms 96ms p=1.000 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,687ms (± 0.33%) 2,671ms (± 0.57%) ~ 2,644ms 2,690ms p=0.065 n=6
Req 2 - geterr 4,364ms (± 0.32%) 4,365ms (± 0.55%) ~ 4,325ms 4,399ms p=0.873 n=6
Req 3 - references 355ms (± 1.66%) 358ms (± 0.91%) ~ 352ms 361ms p=0.226 n=6
Req 4 - navto 290ms (± 0.99%) 287ms (± 1.20%) ~ 282ms 291ms p=0.142 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 3.21%) 78ms (± 1.26%) +3ms (+ 3.76%) 77ms 80ms p=0.024 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,341ms (± 0.59%) 3,356ms (± 0.48%) ~ 3,337ms 3,381ms p=0.148 n=6
Req 2 - geterr 1,825ms (± 3.71%) 1,837ms (± 4.21%) ~ 1,732ms 1,952ms p=0.810 n=6
Req 3 - references 112ms (± 2.64%) 111ms (± 0.99%) ~ 109ms 112ms p=0.415 n=6
Req 4 - navto 347ms (± 1.00%) 343ms (± 1.13%) ~ 337ms 349ms p=0.142 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 434ms (± 0.87%) 433ms (± 0.46%) ~ 431ms 435ms p=0.677 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,558ms (± 0.38%) 2,580ms (± 0.35%) +22ms (+ 0.84%) 2,571ms 2,596ms p=0.006 n=6
Req 2 - geterr 6,012ms (± 0.50%) 6,011ms (± 0.55%) ~ 5,972ms 6,063ms p=0.936 n=6
Req 3 - references 357ms (± 0.60%) 358ms (± 0.57%) ~ 355ms 361ms p=0.371 n=6
Req 4 - navto 277ms (± 1.51%) 275ms (± 0.42%) ~ 274ms 277ms p=0.413 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 99ms (± 4.35%) 102ms (± 1.44%) ~ 99ms 103ms p=0.180 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,815ms (± 1.03%) 2,816ms (± 0.62%) ~ 2,791ms 2,835ms p=1.000 n=6
Req 2 - geterr 4,441ms (± 2.28%) 4,614ms (± 0.43%) ~ 4,593ms 4,641ms p=0.066 n=6
Req 3 - references 368ms (± 0.99%) 370ms (± 0.23%) ~ 369ms 371ms p=0.326 n=6
Req 4 - navto 295ms (± 0.82%) 290ms (± 0.87%) -5ms (- 1.58%) 288ms 295ms p=0.023 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 88ms (± 8.11%) 83ms (± 2.80%) ~ 82ms 88ms p=0.061 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,652ms (± 0.59%) 3,642ms (± 0.43%) ~ 3,621ms 3,666ms p=0.377 n=6
Req 2 - geterr 1,862ms (± 1.14%) 1,846ms (± 1.13%) ~ 1,821ms 1,884ms p=0.471 n=6
Req 3 - references 130ms (± 2.14%) 133ms (± 1.83%) ~ 129ms 136ms p=0.123 n=6
Req 4 - navto 375ms (± 1.60%) 371ms (± 1.41%) ~ 362ms 375ms p=0.419 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 456ms (± 3.23%) 469ms (± 2.00%) ~ 460ms 486ms p=0.054 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53065 6
Baseline main 6

Startup

Comparison Report - main..53065
Metric main 53065 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.27ms (± 0.16%) 142.32ms (± 0.20%) ~ 141.60ms 148.14ms p=0.283 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.87ms (± 0.16%) 226.64ms (± 0.20%) -0.23ms (- 0.10%) 225.65ms 232.44ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.59ms (± 0.16%) 228.62ms (± 0.20%) +0.02ms (+ 0.01%) 227.45ms 234.27ms p=0.018 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.53ms (± 0.15%) 209.63ms (± 0.22%) ~ 208.56ms 216.97ms p=0.293 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53065 6
Baseline main 6

Developer Information:

Download Benchmark

@sandersn
Copy link
Member Author

sandersn commented Mar 2, 2023

Nope, doesn't look like it did anything.

@sandersn sandersn closed this Mar 2, 2023
@sandersn sandersn deleted the lower-jsdoc-comment-state branch March 2, 2023 20:02
@sandersn sandersn mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey Awaiting requested review from jakebailey

Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @typescript-bot