Change default newLine, forceConsistentCasingInFileNames #52298

RyanCavanaugh · 2023-01-19T00:32:08Z

Per discussion at #52296

* Default newline is now lf instead of os-specific * forceConsistentCasingInFilenames now defaults to true

tests/baselines/reference/getEmitOutput-pp.baseline

jakebailey · 2023-01-19T22:44:03Z

src/services/completions.ts

-        const newLineChar = getNewLineCharacter(options, maybeBind(host, host.getNewLine));
+        const newLineChar = getNewLineCharacter(options);


Just to double check, this won't cause our completion snippets to have the wrong newlines, right? This is sort of awkward because it's the input newline character we'd want in snippets, not the output type. I'm not sure if host.getNewLine here was overriding that choice or what, but I guess there's no way this code could have determined the "right" thing to use without using the SourceFile, so, I'm confused.

Hm, the current errors in baselines seem to imply that it does matter?

jakebailey · 2023-01-20T00:23:01Z

After this merges, I think I'll send a PR which tries to add it to .git-blame-ignore-revs and see if it works; it would be convenient at least.

DanielRosenwasser

As Jake mentioned, this is changing up the source-authored newlines used for edits in the LS with the output newlines. Am I missing something or is that intentional?

DanielRosenwasser · 2023-01-20T00:55:49Z

Probably need to update getNewLineOrDefaultFromHost.

jakebailey · 2023-01-20T00:57:13Z

I'm guessing that function is what those snippet printers are supposed to use.

DanielRosenwasser · 2023-01-20T01:00:29Z

Yes, I would assume most instances of getNewLineCharacter in completions.ts should be replaced with (or paired with (unlikely?)) getNewLineOrDefaultFromHost.

jakebailey · 2023-01-20T02:21:02Z

I'm also guessing nobody's noticed because VS Code normalizes them to the desired endings?

RyanCavanaugh · 2023-01-20T19:46:08Z

I'm going to try a reduced subset of this PR to avoid the LS implications, which we don't really want to touch

RyanCavanaugh · 2023-01-20T19:51:22Z

Pared down at #52336

RyanCavanaugh · 2023-01-20T21:34:17Z

OK, I think this is good to go. I've manually tested both settings as well

src/services/completions.ts

Co-authored-by: Jake Bailey <[email protected]>

src/services/completions.ts

src/services/services.ts

src/services/utilities.ts

…eScript into changeDefaults

sheetalkamat · 2023-01-21T00:16:25Z

...ence/tscWatch/programUpdates/updates-errors-when-forceConsistentCasingInFileNames-changes.js

@@ -27,7 +27,21 @@ Output::
 >> Screen clear
 [[90m12:00:15 AM[0m] Starting compilation in watch mode...

-[[90m12:00:20 AM[0m] Found 0 errors. Watching for file changes.
+[96mb.ts[0m:[93m1[0m:[93m43[0m - [91merror[0m[90m TS1149: [0mFile name '/A.ts' differs from already included file name '/a.ts' only in casing.


whats this diff?

Oh because default changed. can you change the test to set forceConsistenCasing to true and false instead of using default so it is actually checking what the test is suppose to check.

sheetalkamat · 2023-01-21T00:18:21Z

...ence/tscWatch/programUpdates/updates-errors-when-forceConsistentCasingInFileNames-changes.js

@@ -27,7 +27,21 @@ Output::
 >> Screen clear
 [[90m12:00:15 AM[0m] Starting compilation in watch mode...

-[[90m12:00:20 AM[0m] Found 0 errors. Watching for file changes.
+[96mb.ts[0m:[93m1[0m:[93m43[0m - [91merror[0m[90m TS1149: [0mFile name '/A.ts' differs from already included file name '/a.ts' only in casing.


Oh because default changed. can you change the test to set forceConsistenCasing to true and false instead of using default so it is actually checking what the test is suppose to check.

jakebailey · 2023-01-21T00:33:02Z

src/services/services.ts

@@ -2437,7 +2437,7 @@ export function createLanguageService(
    }

    function getDocCommentTemplateAtPosition(fileName: string, position: number, options?: DocCommentTemplateOptions): TextInsertion | undefined {
-        return JsDoc.getDocCommentTemplateAtPosition(getNewLineOrDefaultFromHost(host), syntaxTreeCache.getCurrentSourceFile(fileName), position, options);
+        return JsDoc.getDocCommentTemplateAtPosition(getNewLineOrDefaultFromHost(host, /*formatSettings*/ undefined), syntaxTreeCache.getCurrentSourceFile(fileName), position, options);


Not that you should fix it in this PR, but it seems like a bug that we don't have this for JSDoc comments.

src/testRunner/unittests/tscWatch/programUpdates.ts

Co-authored-by: Sheetal Nandi <[email protected]>

DanielRosenwasser · 2023-01-21T00:58:54Z

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

Just for fun.

typescript-bot · 2023-01-21T00:58:58Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at d40ab04. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-21T00:58:58Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at d40ab04. You can monitor the build here.

Update: The results are in!

jakebailey

LGTM (again); I'm pretty sure those last two remaining /*formatSettings*/ undefined are preexisting bugs we should report somewhere.

typescript-bot · 2023-01-21T01:08:39Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52298/merge:

Everything looks good!

DanielRosenwasser · 2023-01-21T01:20:06Z

src/services/shims.ts

@@ -781,7 +781,7 @@ class LanguageServiceShimObject extends ShimBase implements LanguageServiceShim
    }

    private realizeDiagnostics(diagnostics: readonly Diagnostic[]): { message: string; start: number; length: number; category: string; }[] {
-        const newLine = getNewLineOrDefaultFromHost(this.host);
+        const newLine = getNewLineOrDefaultFromHost(this.host, /*formatSettings*/ undefined);


I think this one is probably okay.

typescript-bot · 2023-01-21T02:43:57Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52298/merge:

Everything looks good!

RyanCavanaugh added 2 commits January 18, 2023 16:26

Change default compiler options

daf14b1

* Default newline is now lf instead of os-specific * forceConsistentCasingInFilenames now defaults to true

Update baselines

6744c10

RyanCavanaugh added the Breaking Change Would introduce errors in existing code label Jan 19, 2023

typescript-bot assigned RyanCavanaugh Jan 19, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 19, 2023

RyanCavanaugh mentioned this pull request Jan 19, 2023

Feedback: 5.0 deprecations #51909

Closed

jakebailey reviewed Jan 19, 2023

View reviewed changes

tests/baselines/reference/getEmitOutput-pp.baseline Outdated Show resolved Hide resolved

sheetalkamat approved these changes Jan 19, 2023

View reviewed changes

RyanCavanaugh force-pushed the changeDefaults branch from a9aece8 to 6744c10 Compare January 19, 2023 21:57

jakebailey reviewed Jan 19, 2023

View reviewed changes

jakebailey approved these changes Jan 19, 2023

View reviewed changes

Merge branch 'main' into changeDefaults

38bbc75

DanielRosenwasser requested changes Jan 20, 2023

View reviewed changes

WIP

fbff669

RyanCavanaugh mentioned this pull request Jan 20, 2023

Change default newline + turn on forceConsistentCasingInFileNames #52336

Closed

RyanCavanaugh closed this Jan 20, 2023

RyanCavanaugh reopened this Jan 20, 2023

RyanCavanaugh added 3 commits January 20, 2023 13:27

Update infrastructure + completions to pull correct newline data

38ef9fc

Update baselines

821e678

Update tests

1eda9c8

DanielRosenwasser reviewed Jan 20, 2023

View reviewed changes

src/services/completions.ts Show resolved Hide resolved

Update src/services/completions.ts

319ce9d

Co-authored-by: Jake Bailey <[email protected]>

sheetalkamat reviewed Jan 20, 2023

View reviewed changes

src/services/completions.ts Outdated Show resolved Hide resolved

sheetalkamat reviewed Jan 20, 2023

View reviewed changes

src/services/services.ts Show resolved Hide resolved

sheetalkamat reviewed Jan 20, 2023

View reviewed changes

src/services/utilities.ts Outdated Show resolved Hide resolved

RyanCavanaugh added 3 commits January 20, 2023 15:57

Add missing format options argument

2e48e78

Merge branch 'changeDefaults' of https://github.com/RyanCavanaugh/Typ…

16194c5

…eScript into changeDefaults

Update baselines

7b623a3

sheetalkamat reviewed Jan 21, 2023

View reviewed changes

sheetalkamat requested changes Jan 21, 2023

View reviewed changes

jakebailey reviewed Jan 21, 2023

View reviewed changes

RyanCavanaugh added 2 commits January 20, 2023 16:36

Update test so it does something again

3d2658a

Fix wrong conditional

649e65d

sheetalkamat reviewed Jan 21, 2023

View reviewed changes

src/testRunner/unittests/tscWatch/programUpdates.ts Outdated Show resolved Hide resolved

RyanCavanaugh and others added 2 commits January 20, 2023 16:52

Update src/testRunner/unittests/tscWatch/programUpdates.ts

ea8d98b

Co-authored-by: Sheetal Nandi <[email protected]>

Update test + baseline

d40ab04

jakebailey approved these changes Jan 21, 2023

View reviewed changes

sheetalkamat approved these changes Jan 21, 2023

View reviewed changes

DanielRosenwasser mentioned this pull request Jan 21, 2023

JSDoc comment templates/scaffolding may not use formatter newlines #52348

Closed

DanielRosenwasser reviewed Jan 21, 2023

View reviewed changes

DanielRosenwasser merged commit ff92ab0 into microsoft:main Jan 21, 2023

RyanCavanaugh deleted the changeDefaults branch January 21, 2023 03:57

StephanTLavavej mentioned this pull request Dec 16, 2024

SUGGESTION: enable forceConsistentCasingInFileNames by default #17542

Closed

StephanTLavavej mentioned this pull request Jan 10, 2025

Status Chart: Weekly updates, simplify tsconfig microsoft/STL#5229

Merged

This was referenced Jan 20, 2025

Add TypeScript 5.0 defaults SchemaStore/schemastore#4371

Merged

Add TypeScript 5.0 defaults to the JSON schema microsoft/TypeScript-Website#3304

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default newLine, forceConsistentCasingInFileNames #52298

Change default newLine, forceConsistentCasingInFileNames #52298

RyanCavanaugh commented Jan 19, 2023

jakebailey Jan 19, 2023

jakebailey Jan 19, 2023

jakebailey commented Jan 20, 2023 •

edited

Loading

DanielRosenwasser left a comment

DanielRosenwasser commented Jan 20, 2023

jakebailey commented Jan 20, 2023

DanielRosenwasser commented Jan 20, 2023 •

edited

Loading

jakebailey commented Jan 20, 2023

RyanCavanaugh commented Jan 20, 2023

RyanCavanaugh commented Jan 20, 2023

RyanCavanaugh commented Jan 20, 2023

sheetalkamat Jan 21, 2023

sheetalkamat Jan 21, 2023

sheetalkamat Jan 21, 2023

jakebailey Jan 21, 2023

DanielRosenwasser commented Jan 21, 2023

typescript-bot commented Jan 21, 2023 •

edited

Loading

typescript-bot commented Jan 21, 2023 •

edited

Loading

jakebailey left a comment

typescript-bot commented Jan 21, 2023

DanielRosenwasser Jan 21, 2023

typescript-bot commented Jan 21, 2023

		const newLineChar = getNewLineCharacter(options, maybeBind(host, host.getNewLine));
		const newLineChar = getNewLineCharacter(options);

Change default newLine, forceConsistentCasingInFileNames #52298

Change default newLine, forceConsistentCasingInFileNames #52298

Conversation

RyanCavanaugh commented Jan 19, 2023

jakebailey Jan 19, 2023

Choose a reason for hiding this comment

jakebailey Jan 19, 2023

Choose a reason for hiding this comment

jakebailey commented Jan 20, 2023 • edited Loading

DanielRosenwasser left a comment

Choose a reason for hiding this comment

DanielRosenwasser commented Jan 20, 2023

jakebailey commented Jan 20, 2023

DanielRosenwasser commented Jan 20, 2023 • edited Loading

jakebailey commented Jan 20, 2023

RyanCavanaugh commented Jan 20, 2023

RyanCavanaugh commented Jan 20, 2023

RyanCavanaugh commented Jan 20, 2023

sheetalkamat Jan 21, 2023

Choose a reason for hiding this comment

sheetalkamat Jan 21, 2023

Choose a reason for hiding this comment

sheetalkamat Jan 21, 2023

Choose a reason for hiding this comment

jakebailey Jan 21, 2023

Choose a reason for hiding this comment

DanielRosenwasser commented Jan 21, 2023

typescript-bot commented Jan 21, 2023 • edited Loading

typescript-bot commented Jan 21, 2023 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Jan 21, 2023

DanielRosenwasser Jan 21, 2023

Choose a reason for hiding this comment

typescript-bot commented Jan 21, 2023

jakebailey commented Jan 20, 2023 •

edited

Loading

DanielRosenwasser commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 21, 2023 •

edited

Loading

typescript-bot commented Jan 21, 2023 •

edited

Loading