Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow --module with --out #4918

Closed
wants to merge 4 commits into from
Closed

Conversation

weswigham
Copy link
Member

In #1544 this has been discussed for awhile. The changes to make the basics of it happen are easy, but the repercussions are fairly large for our own code. Our own compiler and projects tests in particular both used --out with --module. Changing the Jakefile to fix our compiler was easy, changes to our projects tests are also complete. @DanielRosenwasser asked me to include this error in #4754, but it impacts our own infrastructure enough in a breaking-change kinda way that it warrants its own PR.

@weswigham
Copy link
Member Author

@mhegazy:

If we do not allow --out with --module, then all non-module files (i.e. no top level import/export) should be coerced in a module output. see #2937 for more details.

This has a curious interaction with how ES6 implicitly has modules sometimes, and may require either a breaking change in our parser API or a breaking change in our tsconfig spec or a breaking change in our behavior regarding ES6 and modules. One of them, depending on what we'd rather do. I think that part of this, specifically, should probably be filed as a seperate bug, after looking into it.

@weswigham weswigham changed the title WIP: Disallow --module or ES6 modules with --out Disallow --module or ES6 modules with --out Sep 25, 2015
@weswigham
Copy link
Member Author

Ping @DanielRosenwasser - I think this is complete as far as this PR is concerned. We'll need to file followup issues regarding implementation of @mhegazy's change and how it interacts with --target es6.

@weswigham weswigham changed the title Disallow --module or ES6 modules with --out Disallow --module with --out Sep 25, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Sep 28, 2015

I would say let's get --module and --out working instead of disallowing it and then allowing it again. it is a breaking change either ways.

@mhegazy
Copy link
Contributor

mhegazy commented Sep 29, 2015

as discussed offline, let's close this and support --module and --out combination.

@mhegazy mhegazy closed this Sep 29, 2015
@weswigham weswigham deleted the 1544-error branch August 17, 2017 23:01
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants