🤖 User test baselines have changed for refs/heads/master #41496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
aca8652 to
95ac889
Compare
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-bot
added
the
For Uncommitted Bug
typescript-bot
force-pushed
the
user-baseline-updates
branch
4 times, most recently
from
00d458c to
57d2d95
Compare
nitish-awasthi
approved these changes
Dec 2, 2020
typescript-bot
force-pushed
the
user-baseline-updates
branch
21 times, most recently
from
d021d71 to
06efed7
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
26 times, most recently
from
8f31582 to
e986fcf
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
e986fcf to
b3c90ca
Compare
sandersn
approved these changes
Jan 15, 2021
| src/app.ts(116,30): error TS2339: Property 'returnTo' does not exist on type 'Session & Partial<SessionData>'. | ||
| src/config/passport.ts(14,5): error TS2349: This expression is not callable. | ||
| Type 'User' has no call signatures. | ||
| src/config/passport.ts(18,24): error TS7006: Parameter 'err' implicitly has an 'any' type. |
There was a problem hiding this comment.
passport usage is oodate now -- this repo is bitrotting quickly now
| src/controllers/user.ts(101,46): error TS7006: Parameter 'err' implicitly has an 'any' type. | ||
| src/controllers/user.ts(101,51): error TS7006: Parameter 'existingUser' implicitly has an 'any' type. | ||
| src/controllers/user.ts(146,29): error TS7006: Parameter 'err' implicitly has an 'any' type. | ||
| src/controllers/user.ts(153,19): error TS2769: No overload matches this call. |
| @@ -1,17 +1,20 @@ | |||
| Exit Code: 2 | |||
| Standard output: | |||
| lib/adapters/http.js(13,19): error TS2732: Cannot find module './../../package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension. | |||
| lib/adapters/http.js(84,22): error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'. | |||
| lib/adapters/http.js(22,12): error TS2304: Cannot find name 'AxiosProxyConfig'. | |||
There was a problem hiding this comment.
new since last baseline update, it's in index.d.ts but not imported here
| @@ -1,48 +1,5 @@ | |||
| Exit Code: 2 | |||
| Standard output: | |||
| node_modules/debug/dist/debug.js(3,100): error TS2539: Cannot assign to '_typeof' because it is not a variable. | |||
There was a problem hiding this comment.
debug doesn't ship a dist/ directory anymore...?
| @@ -0,0 +1,10 @@ | |||
| Exit Code: 2 | |||
| Standard output: | |||
| test/Either.ts(244,33): error TS2345: Argument of type 'Either<string, never>' is not assignable to parameter of type 'Either<`invalid color ${string}`, string>'. | |||
There was a problem hiding this comment.
const errorHandler = (s: string) => `invalid color ${s}`
now creates a unwanted template literal type 🙄
| created packages/vue/dist/vue.esm-browser.prod.js in ?s | ||
| /vue-next/packages/vue/src/runtime.ts → packages/vue/dist/vue.runtime.esm-browser.prod.js... | ||
| created packages/vue/dist/vue.runtime.esm-browser.prod.js in ?s | ||
| [!] (plugin rpt2) Error: /vue-next/packages/reactivity/src/baseHandlers.ts(192,3): semantic error TS2322: Type '(target: object) => (string | number | symbol)[]' is not assignable to type '(target: object) => ArrayLike<string | symbol>'. |
There was a problem hiding this comment.
error is correct; vue's function ownKeys should return (string | symbol)[] not (string | number | symbol)[]. This is a breaking change for 4.2 from #41987.
@DanielRosenwasser do we normally document lib or DOM breaks in the release notes? I don't think we do.
| 22 declare const getPropertyName: (node: TSESTree.MemberExpression | TSESTree.Property | TSESTree.MethodDefinition, initialScope?: import("@typescript-eslint/scope-manager/dist/scope/BlockScope").BlockScope | import("@typescript-eslint/scope-manager/dist/scope/CatchScope").CatchScope | import("@typescript-eslint/scope-manager/dist/scope/ClassScope").ClassScope | import("@typescript-eslint/scope-manager/dist/scope/ConditionalTypeScope").ConditionalTypeScope | import("@typescript-eslint/scope-manager/dist/scope/ForScope").ForScope | import("@typescript-eslint/scope-manager/dist/scope/FunctionExpressionNameScope").FunctionExpressionNameScope | import("@typescript-eslint/scope-manager/dist/scope/FunctionScope").FunctionScope | import("@typescript-eslint/scope-manager/dist/scope/FunctionTypeScope").FunctionTypeScope | import("@typescript-eslint/scope-manager/dist/scope/GlobalScope").GlobalScope | import("@typescript-eslint/scope-manager/dist/scope/MappedTypeScope").MappedTypeScope | import("@typescript-eslint/scope-manager/dist/scope/ModuleScope").ModuleScope | import("@typescript-eslint/scope-manager/dist/scope/SwitchScope").SwitchScope | import("@typescript-eslint/scope-manager/dist/scope/TSEnumScope").TSEnumScope | import("@typescript-eslint/scope-manager/dist/scope/TSModuleScope").TSModuleScope | import("@typescript-eslint/scope-manager/dist/scope/TypeScope").TypeScope | import("@typescript-eslint/scope-manager/dist/scope/WithScope").WithScope | undefined) => string | null; | ||
| ...260 lines omitted... | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| src/rules/ts-use-interface-parameters.ts:13:8 - error TS2307: Cannot find module '@typescript-eslint/typescript-estree/dist/parser-options'. |
There was a problem hiding this comment.
@weswigham this works fine from the editor. Can you investigate why our build of azure-sdk is failing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript