Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not watch root folders for failed lookup locations and effective type roots #19239

Merged
merged 2 commits into from
Oct 17, 2017

Conversation

sheetalkamat
Copy link
Member

Fixes #19170

@mhegazy
Copy link
Contributor

mhegazy commented Oct 17, 2017

@mjbvz can you give this a quick test on the vscode scenario in #19170

@sheetalkamat sheetalkamat merged commit 314172a into master Oct 17, 2017
@sheetalkamat sheetalkamat deleted the reduceWatchedDirectories branch October 17, 2017 20:05
@mjbvz
Copy link
Contributor

mjbvz commented Oct 17, 2017

Thanks for taking a look. Things look much better for tsserver responsiveness now. The log file does still grow fairly large and there are a number of log events for sub node_modules directories, such as build/lib/watch/node_modules:

Info 36810[14:33:46.246] DirectoryWatcher recursive:: Trigger: /Users/matb/projects/vscode/build/lib/watch/node_modules/.staging/fsevents-4d579504/node_modules/readable-stream/lib/_stream_passthrough.js PathInfo: /Users/matb/projects/vscode Project: /Users/matb/projects/vscode/src/tsconfig.json WatchType: Directory of Failed lookup locations in module resolution

Should these be excluded as well?

@sheetalkamat
Copy link
Member Author

Sadly there is no way to exclude that and still keep project upto date.. The watched folder vscode will exist since the module resolution strategy for your project is amd, program is going to lookup files in this folder to resolve module names. Note that even though this is logged, it is not actionable since we eliminate many file additions/removals

@mhegazy
Copy link
Contributor

mhegazy commented Oct 17, 2017

Adding baseUrl and using moduleResolution: node should make sure that we only look under the source folder and do not walk higher (except for node_modules).

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants