Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have getNameOfDeclaration return x for export default x. #18616

Merged
1 commit merged into from
Oct 6, 2017
Merged

Have getNameOfDeclaration return x for export default x. #18616

1 commit merged into from
Oct 6, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 20, 2017

Fixes #17990

@ghost ghost force-pushed the export_default branch from 1f76c8d to dc8c718 Compare September 20, 2017 21:44
@ghost ghost changed the title Have getDeclarationName return x for export default x. Have getNameOfDeclaration return x for export default x. Sep 20, 2017
@ghost ghost force-pushed the export_default branch from dc8c718 to fac3b64 Compare September 20, 2017 21:57
@ghost ghost requested review from rbuckton and sandersn September 22, 2017 16:43
@ghost
Copy link
Author

ghost commented Sep 29, 2017

@sandersn @rbuckton Any comments?

@ghost ghost merged commit 71f8852 into master Oct 6, 2017
@ghost ghost deleted the export_default branch October 6, 2017 21:29
@weswigham weswigham mentioned this pull request Oct 23, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandersn @msftclas @msftgits