Explicitly avoid canonicalizing paths during configuration handling #18316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Andy-MS Would you take a look at this? |
ghost
approved these changes
Sep 7, 2017
src/compiler/core.ts
Outdated
| @@ -1228,6 +1228,9 @@ namespace ts { | |||
| /** Does nothing. */ | |||
| export function noop(): void {} | |||
|
|
|||
| /** Passes thru argument. */ | |||
| export function identity<T>(x: T) { return x; } | |||
There was a problem hiding this comment.
This could also replace identityMapper in checker.ts.
src/compiler/commandLineParser.ts
Outdated
| @@ -1577,7 +1577,7 @@ namespace ts { | |||
| errors.push(createCompilerDiagnostic(Diagnostics.Compiler_option_0_requires_a_value_of_type_1, "extends", "string")); | |||
| } | |||
| else { | |||
| const newBase = configFileName ? getDirectoryPath(toPath(configFileName, basePath, getCanonicalFileName)) : basePath; | |||
| const newBase = configFileName ? getDirectoryPath(toPath(configFileName, basePath, identity)) : basePath; | |||
There was a problem hiding this comment.
Might want to create a local toPath function delegating to ts.toPath that explains why we use identity here.
src/compiler/core.ts
Outdated
| @@ -1228,6 +1228,9 @@ namespace ts { | |||
| /** Does nothing. */ | |||
| export function noop(): void {} | |||
|
|
|||
| /** Passes thru argument. */ | |||
ghost
mentioned this pull request
…use identity in checker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this comment,
forceConsistentCasingInFileNamesrelies on paths not being canonicalized until later in the process; so this replaces new usages ofgetCanonicalFileNamein the configuration parser with anidentityfunction, so as to avoid canonicalizing the path when it is not needed.