Code

Extract method#16960

Code

Closed

RyanCavanaugh wants to merge 60 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom RyanCavanaugh:extract-methodRyanCavanaugh/TypeScript:extract-methodCopy head branch name to clipboard

Commits

Commits on Jun 30, 2017

• Rebased EM WIP

  RyanCavanaugh

  committed
  be27a1a

  Copy full SHA for be27a1a

Commits on Jul 5, 2017

• Change refactor api in fourslash

  RyanCavanaugh

  committed
  e798257

  Copy full SHA for e798257

• Add comments

  RyanCavanaugh

  committed
  bf176a6

  Copy full SHA for bf176a6

• Better baselines

  RyanCavanaugh

  committed
  0130ebb

  Copy full SHA for 0130ebb

• Rename test we we can run it independent of unit tests

  RyanCavanaugh

  committed
  bbf5cd7

  Copy full SHA for bbf5cd7

• Change fourslash refactor API

  RyanCavanaugh

  committed
  9dd6bef

  Copy full SHA for 9dd6bef

• Remove invalid assert

  RyanCavanaugh

  committed
  f21b7ae

  Copy full SHA for f21b7ae

• Fix undefined computation of length

  RyanCavanaugh

  committed
  674b1bf

  Copy full SHA for 674b1bf

• Improved type baselines for EM .js

  RyanCavanaugh

  committed
  9367473

  Copy full SHA for 9367473

• Add validation to fourslash test

  RyanCavanaugh

  committed
  1ea9972

  Copy full SHA for 1ea9972

• Move text to diagnostic messages

  RyanCavanaugh

  committed
  1787fa8

  Copy full SHA for 1787fa8

• Merge branch 'master' into extract-method

  RyanCavanaugh

  committed
  fb89c00

  Copy full SHA for fb89c00

• Properly widen literal param types + emit correct return statements for exprs

  RyanCavanaugh

  committed
  4aef5e7

  Copy full SHA for 4aef5e7

Commits on Jul 6, 2017

• Don't offer to extract lone identifiers

  RyanCavanaugh

  committed
  b5c5c40

  Copy full SHA for b5c5c40

• Don't fail if span is zero-length

  RyanCavanaugh

  committed
  b1fa49f

  Copy full SHA for b1fa49f

• Don't crash when span is empty

  RyanCavanaugh

  committed
  825237b

  Copy full SHA for 825237b

Commits on Jul 18, 2017

• Restore assert and fix synthetic type node creation

  RyanCavanaugh

  committed
  aa6f3aa

  Copy full SHA for aa6f3aa

• Re-use noop

  RyanCavanaugh

  committed
  b7e4451

  Copy full SHA for b7e4451

• Address portion of CR feedback

  RyanCavanaugh

  committed
  419a4c2

  Copy full SHA for 419a4c2

Commits on Jul 19, 2017

• Only compute changes for requested refactors

  RyanCavanaugh

  committed
  4218738

  Copy full SHA for 4218738

• Address more PR comments

  RyanCavanaugh

  committed
  6d2bc90

  Copy full SHA for 6d2bc90

• Merge master

  RyanCavanaugh

  committed
  9a24549

  Copy full SHA for 9a24549

• Remove WS

  RyanCavanaugh

  committed
  271ecb1

  Copy full SHA for 271ecb1

• Emit return types in ctxly-typed functions and don't emit annotations in JS

  RyanCavanaugh

  committed
  bdefcc3

  Copy full SHA for bdefcc3

• Fix broken test

  RyanCavanaugh

  committed
  6428b1e

  Copy full SHA for 6428b1e

• Handle fn params and duplicated scope names properly

  RyanCavanaugh

  committed
  8af8ac2

  Copy full SHA for 8af8ac2

• Re-use isJS result

  RyanCavanaugh

  committed
  ede6671

  Copy full SHA for ede6671

• You may not extract-method on exported declarations

  RyanCavanaugh

  committed
  55b28ad

  Copy full SHA for 55b28ad

Commits on Jul 20, 2017

• Correctly apply overlapped edits in fourslash

  RyanCavanaugh

  committed
  2d9eaa9

  Copy full SHA for 2d9eaa9

• Fix some parenting issues & start detecting stranded references

  RyanCavanaugh

  committed
  2f2c780

  Copy full SHA for 2f2c780

• Add return type annotation and regression test for a prior assert

  RyanCavanaugh

  committed
  63193da

  Copy full SHA for 63193da

Commits on Jul 24, 2017

• Detect would-be stranded references to extracted declarations

  RyanCavanaugh

  committed
  889292a

  Copy full SHA for 889292a

• Tests

  RyanCavanaugh

  committed
  e229d42

  Copy full SHA for e229d42

• Fix line ending

  RyanCavanaugh

  committed
  7b2dd8a

  Copy full SHA for 7b2dd8a

Commits on Jul 25, 2017

• Function blocks aren't statements!

  RyanCavanaugh

  committed
  bf6c0a9

  Copy full SHA for bf6c0a9

• Disallow certain classes of refactors

  RyanCavanaugh

  committed
  3424312

  Copy full SHA for 3424312

• Add test

  RyanCavanaugh

  committed
  ff18df3

  Copy full SHA for ff18df3

• Handle static methods and static method name conflicts

  RyanCavanaugh

  committed
  7f29fcd

  Copy full SHA for 7f29fcd

• Merge

  RyanCavanaugh

  committed
  d39d95b

  Copy full SHA for d39d95b

Commits on Jul 28, 2017

• No extracting other non-statement blocks

  RyanCavanaugh

  committed
  dda5496

  Copy full SHA for dda5496

• More disallowed extraction position

  RyanCavanaugh

  committed
  e88ff21

  Copy full SHA for e88ff21

• Block more nonworking extraction locations

  RyanCavanaugh

  committed
  bd80005

  Copy full SHA for bd80005

• Properly enumerate class blocks

  RyanCavanaugh

  committed
  ff716d0

  Copy full SHA for ff716d0

• Add tests task

  RyanCavanaugh

  committed
  1291cfd

  Copy full SHA for 1291cfd

• Don't re-use nodes

  RyanCavanaugh

  committed
  a26790f

  Copy full SHA for a26790f

• Correctly detect JavaScriptness

  RyanCavanaugh

  committed
  56e1d6d

  Copy full SHA for 56e1d6d

Commits on Jul 31, 2017

• Create multi-line bodies

  RyanCavanaugh

  committed
  7f3a0a8

  Copy full SHA for 7f3a0a8

Commits on Aug 3, 2017

• Add support for validating specific refactor actions' availability

  RyanCavanaugh

  committed
  003cd0a

  Copy full SHA for 003cd0a

• More testcases

  RyanCavanaugh

  committed
  a76664c

  Copy full SHA for a76664c

• Accept baselines

  RyanCavanaugh

  committed
  42e0652

  Copy full SHA for 42e0652

• Innumerable bugfixes

  RyanCavanaugh

  committed
  46a84c3

  Copy full SHA for 46a84c3

• Merge branch 'master' into extract-method

  RyanCavanaugh

  committed
  a97ab93

  Copy full SHA for a97ab93

• Add additional test

  RyanCavanaugh

  committed
  37ae957

  Copy full SHA for 37ae957

Commits on Aug 4, 2017

• Fix some class scenarios (static methods, readonly inits in ctor)

  RyanCavanaugh

  committed
  2adb2b3

  Copy full SHA for 2adb2b3

• Prevent extraction of exported variables

  RyanCavanaugh

  committed
  ba37830

  Copy full SHA for ba37830

• No extraction of ambient declarations

  RyanCavanaugh

  committed
  4dafb40

  Copy full SHA for 4dafb40

• Put __return first

  RyanCavanaugh

  committed
  c1c7e83

  Copy full SHA for c1c7e83

• Don't wrongly exclude accessor in indexed access exprs

  RyanCavanaugh

  committed
  a4c41b8

  Copy full SHA for a4c41b8

• Share selection logic; fix typos

  RyanCavanaugh

  committed
  b5a88c1

  Copy full SHA for b5a88c1

• Merge branch 'master' into extract-method

  RyanCavanaugh

  committed
  568d5f6

  Copy full SHA for 568d5f6