Error when emitting the declaration for an exported class that extends an intersection #14074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error when emitting an extends clause for a type that has no symbol. This error only occurs on exported classes. This prevents the emitter from producing types that extend from intersections, which are not parseable right now.
mhegazy
approved these changes
Feb 14, 2017
|
@sandersn can you also file an issue to track parsing the intersection types in heritage clauses. |
DanielRosenwasser
requested changes
Feb 14, 2017
src/compiler/diagnosticMessages.json
Outdated
| @@ -2352,6 +2352,10 @@ | |||
| "category": "Error", | |||
| "code": 4092 | |||
| }, | |||
| "Extends clause of exported class '{0}' refers to a type with no declaration.": { | |||
There was a problem hiding this comment.
a type whose name cannot be referenced.
DanielRosenwasser
requested changes
Feb 14, 2017
src/compiler/diagnosticMessages.json
Outdated
| @@ -2352,6 +2352,10 @@ | |||
| "category": "Error", | |||
| "code": 4092 | |||
| }, | |||
| "Extends clause of exported class '{0}' refers to a type whose name cannot be referenced.": { | |||
There was a problem hiding this comment.
Nit: "The 'extends clause of exported class...
There was a problem hiding this comment.
Are you sure? All the other messages like this just start with "Extends clause ...".
There was a problem hiding this comment.
A couple of minutes with @RyanCavanaugh turned up another option we liked even more: 'extends' clause of exported class ...
I'll go with that and update all the other error messages to match.
Refer to "'extends' clause" instead of "Extends clause".
|
@sandersn please cherry-pick this in release-2.2 |
|
@mhegazy done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14017 by making the mixin emit illegal.