Use a symbol for untyped modules to distinguish from unknownSymbol #12352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
untyped_module_symbol
branch
from
428bb26 to
64f17c5
Compare
mhegazy
suggested changes
Dec 22, 2016
src/compiler/checker.ts
Outdated
| // Failed imports and untyped modules are both treated in an untyped manner; only difference is whether we give a diagnostic first. | ||
| return undefined; | ||
| // Unlike a failed import, an untyped module produces a dummy symbol. This is checked for by `isUntypedOrShorthandAmbientModuleSymbol`. | ||
| const untypedSymbol = createSymbol(SymbolFlags.ValueModule, `"${moduleName}"`); |
There was a problem hiding this comment.
why not return unknownSymbol here instead?
creating a new symbol with no backing declaration would cause other issues in the future.
There was a problem hiding this comment.
Returning undefined effectively does that. But if we return unknownSymbol, then getBaseConstructorTypeOfClass will see that and won't create an error message.
There was a problem hiding this comment.
how about a new unknownModule instead?
added 5 commits
January 25, 2017 06:39
… creating a new one for each module.
mhegazy
approved these changes
Mar 1, 2017
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12329
getBaseConstructorTypeOfClassspecifically checks forunknownTypebefore issuing an error.We actually undid this (and just used
unknownSymbol) in #11962. So we should be sure this is what we want.