Fix comparable in switch #11633
Merged
Fix comparable in switch #11633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch was missing the rule for converting literal types to the literal base type if needed.
Since all callers need this check -- it's how equality is supposed to work everywhere.
There are more literal types in error messages because error reporting no longer has the advantage of calls to getBaseLiteralType
|
@DanielRosenwasser I found a pretty good solution to make this fix cleaner. It drops more literal types into error messages, but is otherwise not bad. |
|
@DanielRosenwasser I believe you knew about this code since you refactored comparability this year. Can you review it? |
This improves error messages
DanielRosenwasser
requested changes
Nov 1, 2016
|
@aozgaa weren't you working on a similar bug regarding intersection type comparability? What was the outcome of that? |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10892
switchshould use the same rules as===, so I pushed the calls togetBaseTypeOfLiteralTypeintoisTypeEqualityComparableTo, which bothcheckBinaryLikeExpressionandcheckSwitchStatementcall.