Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pathForLibFile needs improvement in program reuse, default library detection and other uses #52759

Closed
sheetalkamat opened this issue Feb 14, 2023 · 0 comments · Fixed by #53877
Closed

pathForLibFile needs improvement in program reuse, default library detection and other uses #52759

sheetalkamat opened this issue Feb 14, 2023 · 0 comments · Fixed by #53877
Assignees
@sheetalkamat
Labels
Fix Available A PR has been opened for this issue

Comments

@sheetalkamat
Copy link
Member

Bug Report

🔎 Search Terms

🕗 Version & Regression Information

⏯ Playground Link

💻 Code

🙁 Actual behavior

  • Module resolution for libFile redirects is not stored.
  • Should it use different module resolution cache that one in program if resolution strategy doesn't match
  • Resolution happens each time isSourceFileDefaultLibrary and getLibFileFromReference are called.

🙂 Expected behavior
@sheetalkamat sheetalkamat self-assigned this Feb 14, 2023
sheetalkamat added a commit that referenced this issue Apr 17, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
092497e 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 17, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
6bc76b1 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 18, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
9dce12f 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 18, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
d9a19e3 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 18, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
4dd23b8 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 18, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
3ca7531 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 20, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
c54cfef 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 20, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
d171bb6 
…reused

Fixes #52759, #52707
sheetalkamat added a commit that referenced this issue Apr 20, 2023
@sheetalkamat
Add resolveLibrary method on hosts so that library resolution can be …
fc8c4da 
…reused

Fixes #52759, #52707
@sheetalkamat sheetalkamat mentioned this issue Apr 20, 2023
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheetalkamat sheetalkamat

Labels
Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
No milestone
2 participants
@sheetalkamat @typescript-bot