Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation page i18n #246

Merged
merged 1 commit into from
Feb 12, 2020
Merged

documentation page i18n #246

merged 1 commit into from
Feb 12, 2020

Conversation

evanSe
Copy link
Contributor

@evanSe evanSe commented Feb 12, 2020 •
edited
Loading

part of #100
Starting off some internationalization in the documentation page.

@msftclas
Copy link

msftclas commented Feb 12, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@evanSe evanSe changed the title initial documentation i18n documentation page i18n Feb 12, 2020
@evanSe
Copy link
Contributor Author

evanSe commented Feb 12, 2020

Hey @orta here is an initial go at internationalization for the documentation.ts based on your comment.

Is this what you had in mind? Happy to change anything!

@evanSe evanSe marked this pull request as ready for review February 12, 2020 22:05
@evanSe evanSe requested a review from orta February 12, 2020 22:06
@orta
Copy link
Contributor

orta commented Feb 12, 2020

This is a great PR, and everything looks perfect. Congrats!

2020-02-12 17-22-59 2020-02-12 17_23_57

@orta orta merged commit 6b29cbe into microsoft:v2 Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanSe @msftclas @orta