Adds dark mode to the site #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orta
commented
Jan 19, 2020
orta
commented
- Moves to using SCSS vars
- Switches to supporting whatever the OS offers in dark vs light
|
getting the twoslash code samples to work this way is out of scope for this PR (it's tricky, shocker) |
Lighthouse Scores
|
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.93 | 1 | 0.93 | 0.88 | 0.74 |
/en/tsconfig
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.97 | 0.97 | 1 | 0.86 | 0.7 |
/docs/handbook/integrating-with-build-tools.html
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.99 | 0.93 | 1 | 0.89 | 0.74 |
Snapshots updated
backstop_default_Empty_Page_0_document_0_phone.png
| Before | After |
|---|---|
 |
 |
backstop_default_Empty_Page_0_document_1_tablet.png
| Before | After |
|---|---|
 |
 |
backstop_default_Empty_Page_0_document_2_computer.png
| Before | After |
|---|---|
 |
 |
backstop_default_Index_0_document_0_phone.png
| Before | After |
|---|---|
 |
 |
backstop_default_Index_0_document_1_tablet.png
| Before | After |
|---|---|
 |
 |
backstop_default_Index_0_document_2_computer.png
| Before | After |
|---|---|
 |
 |
backstop_default_Old_Handbook_Example_0_viewport_0_phone.png
| Before | After |
|---|---|
 |
 |
backstop_default_Old_Handbook_Example_0_viewport_1_tablet.png
| Before | After |
|---|---|
 |
 |
backstop_default_Old_Handbook_Example_0_viewport_2_computer.png
| Before | After |
|---|---|
 |
 |
backstop_default_TSConfig_Example_0_viewport_0_phone.png
| Before | After |
|---|---|
 |
 |
backstop_default_TSConfig_Example_0_viewport_1_tablet.png
| Before | After |
|---|---|
 |
 |
backstop_default_TSConfig_Example_0_viewport_2_computer.png
| Before | After |
|---|---|
 |
 |
|
Shipped a PR which would allow snapshot testing of dark mode, garris/BackstopJS#1143, I'm gonna make quite a lot of those tests to because I don't use dark mode personally. |
|
OK, this is shippable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.