-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS add some missing static functions #22
JS add some missing static functions #22
Conversation
The last commit add also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the advantage of a static method over the direct constructor usage?
Any excepts that it matches with the
It's just a small comfort to make them existing! I don't see any reason to refuse implementing them in |
Indeed, Java version has from(), too. It is the original TSS.Net that does not have it. Thank you for your contribution! I'm going to merge it now. One note, in case you'll be doing any additions in the future. TpmTypes.js is actually an auto-generated file, so please do not change anything in existing methods or comments, as these changes will be lost. And in order to add new methods I'll add a new snippets file src/TpmExtensions.js.snips, similar to how it is done in TSS.Java. |
This PR add two more useful functions:
from()
forTPM_HANDLE
classnullTicket()
forTPMT_TK_HASHCHECK
classIt’s a small step forward in the hope of seeing the JS library functional one day! (
PCR_Read()
is not working for example…)