Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ignorable waits CHECKPOINT_QUEUE, PARALLEL_REDO_WORKER_WAIT_WORK, QDS_ASYNC_QUEUE, PWAIT_EXTENSIBILITY_CLEANUP_TASK #266

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

PiJoCoder
Copy link
Contributor

The goal is to not show these as noise in the Bottleneck Analysis report.

One wait to test this is to create a SQL LogScout perfstats collection and manually go in the output file and add these wait types in the output. Then import and watch them not show up.
You can also run this query after importing SQL Nexus and check if they are showing as "IGNORABLE" in the wait_category column

  use sqlnexus
  go
  select  wait_type, wait_category from tbl_OS_WAIT_STATS 
  where wait_type in 
  ('CHECKPOINT_QUEUE', 
  'QDS_ASYNC_QUEUE',
  'PARALLEL_REDO_WORKER_WAIT_WORK', 
  'PWAIT_EXTENSIBILITY_CLEANUP_TASK')

…IT_WORK, QDS_ASYNC_QUEUE, PWAIT_EXTENSIBILITY_CLEANUP_TASK
@asavioliMSFT
Copy link
Contributor

Compared bottleneck analysis from a customer's data

Current nexus version

image

PR version - we can see Parallel_redo_worker_wait_work is no longer there

image

Performed some updates to force having a QDS_ASYNC_QUEUE on one of my collections.

With current nexus build

image

With PR build

image

Copy link
Contributor

@asavioliMSFT asavioliMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved.

It doesn't cause a problem, but I noticed that that CHECKPOINT_QUEUE was already there at the beginning of the IN clause, which means this wait was already ignored. So, adding it again was not required

@PiJoCoder
Copy link
Contributor Author

PR approved.

It doesn't cause a problem, but I noticed that that CHECKPOINT_QUEUE was already there at the beginning of the IN clause, which means this wait was already ignored. So, adding it again was not required

Thank you, good catch.

@PiJoCoder PiJoCoder merged commit c2bf6f9 into master Dec 12, 2023
@PiJoCoder PiJoCoder deleted the IgnorableWaitTypes_Pijocoder_111623 branch December 12, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants