Fix #232 (report appears if all tables are there) #247 (fix working set trimming report) and #243 (add CCC rule) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n SQL Perf Main report when not all tables are present worked on the microsoft#232
some Microsoft modules uses company name "Microsoft Corp." instead of "Microsoft Corporation" , no need to highlight them. Added an additional if condition to the background color field.
Just removed the field "Indicators" Should we add [IndicatorsProcess] ,[IndicatorsSystem] ,[IndicatorsPool] instead ?
Added [IndicatorsProcess] ,[IndicatorsSystem] ,[IndicatorsPool] as part of discussion under microsoft#247.
added rule "Common Criteria Compliance Enabled" and stored procedure usp_CCC_Enabled for the Rule
PiJoCoder
changed the title
|
@hacitandogan thank you for all this work. Just saw this today. I'll be testing and providing feedback. Thank you |
|
@hacitandogan thank you
|
update NexusReports\NexusReports.rptproj.rsuser to revert it back to original state
added missing EXEC statement for activating the rule.
|
@PiJoCoder |
Looks like it worked. I don't see the file listed as one of the changed ones: |
|
Tested Common criteria compliance rule - looks good |
|
Thank you @hacitandogan - great work on these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worked on the issue #232
Although this should prevent those errors , for future maybe we should consider some of our reports to handle these kind of situations.(Especially when the partial information is still meaningfull even if you have some data missing )