Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if the version of Python found is too old #810

Merged
merged 4 commits into from
May 12, 2020
Merged

Fail if the version of Python found is too old #810

merged 4 commits into from
May 12, 2020

Conversation

cbezault
Copy link
Contributor

@cbezault cbezault commented May 7, 2020 •
edited
Loading

We require at least Python 3.8.

Partially addresses #806 .

@cbezault cbezault added the test Related to test code label May 7, 2020
@cbezault cbezault requested a review from a team as a code owner May 7, 2020 17:15
@cbezault cbezault marked this pull request as draft May 7, 2020 17:37
@cbezault cbezault marked this pull request as ready for review May 7, 2020 17:41
@CaseyCarter
Copy link
Contributor

Partially resolves #806 .

GitHub sees "resolves #806" here, so it will close #806 when this merges. If that's not your intent, you can change this to "Partially addresses #806" which will link the two but not autoclose on merge.

@CaseyCarter CaseyCarter self-assigned this May 12, 2020
@CaseyCarter CaseyCarter merged commit fec52ca into microsoft:master May 12, 2020
@CaseyCarter
Copy link
Contributor

Thank you for sharing your failure with the STL!

@CaseyCarter CaseyCarter removed their assignment Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbezault @CaseyCarter @StephanTLavavej