C++20 move_iterator changes and move_sentinel #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes primarily come from P0896R4 "<ranges>", but the `operator<=>` from P1614R2 "Adding Spaceship <=> To The Library" is here as well. I've also speculatively implemented the proposed resolutions of LWG-3293, LWG-3391, and LWG-3435. I had to [patch a pair of libc++ tests](https://reviews.llvm.org/D79343) that fail with these changes; I'll update the LLVM reference herein once those changes merge upstream. Drive-by: * s/explicit constexpr/constexpr explicit/g (I somehow managed to sneak two occurrences into `subrange`)
StephanTLavavej
requested changes
May 5, 2020
miscco
reviewed
May 5, 2020
miscco
reviewed
May 5, 2020
StephanTLavavej
approved these changes
May 7, 2020
cbezault
approved these changes
May 7, 2020
StephanTLavavej
approved these changes
May 7, 2020
|
Thanks for this... 😎 ...moving contribution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes primarily come from P0896R4 "
<ranges>", but theoperator<=>from P1614R2 "Adding Spaceship<=>To The Library" is here as well.I've also speculatively implemented the proposed resolutions of LWG-3293, LWG-3391, and LWG-3435.
I had to patch a pair of libc++ tests that fail with these changes; I'll update the LLVM reference herein once those changes merge upstream. (These are the failing tests.)
Drive-by:
subrange)