C++20 reverse_iterator changes #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes primarily came from P0896R4 "`<ranges>`", but the `operator<=>` from P1614R1 "Adding Spaceship `<=>` To The Library" is here as well. I had to patch a pair of libc++ tests for an extension that allows `std::map<int, X>::reverse_iterator` (resp. `std::multimap<int, X>::reverse_iterator`) to be instantiated when `X` is incomplete; this extension is no longer possible in C++20. Drive-by: * LWG-3413 has a number now * Remove workarounds for VSO-612785 which seems not to reproduce with current EDG
StephanTLavavej
approved these changes
Apr 29, 2020
barcharcraz
approved these changes
Apr 30, 2020
StephanTLavavej
approved these changes
Apr 30, 2020
|
Related to #39 P0896R4 (@CaseyCarter, your original checkin notes said P1614R1, which was an earlier revision.) |
|
!machinery |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes primarily came from P0896R4 "
<ranges>", but theoperator<=>from P1614R2 "Adding Spaceship<=>To The Library" is here as well.I had to patch a pair of libc++ tests for an extension that allows
std::map<int, X>::reverse_iterator(resp.std::multimap<int, X>::reverse_iterator) to be instantiated whenXis incomplete; this extension is no longer possible in C++20.Drive-by:
Remove workarounds for VSO-612785 which seems not to reproduce with current EDG(Still needed for CUDA 9.2 in our Microsoft-internal test suite.)