Require MSVC 19.26 and Clang 10 in the STL #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `<yvals_core.h>` changes: * Clang 10 `_HAS_CONDITIONAL_EXPLICIT` in C++14 mode (Only CUDA now requires the `_HAS_CONDITIONAL_EXPLICIT == 0` code paths) * reject Clang < 10 * reject MSVC < 1926 * Unskip libc++ tests that need Concepts and/or `<=>` * `std/tests/P0595R2_is_constant_evaluated`: We no longer need suppress the warning Clang 9 emits when it sees the suppression for the warning Clang 10 emits in this test ;) * `std/tests/VSO_0157762_feature_test_macros`: Remove Clang 9 support * `std/tests/concepts_matrix.lst`: This is now simply a copy of `usual_latest_matrix.lst` with the `/BE` lines (EDG configs) commented out. (i.e., we now run the Concepts tests with Clang as well as MSVC.) * Remove workarounds for LLVM-38491 "clang-cl should accept __declspec(allocator)": Replace uses of `_DECLSPEC_ALLOCATOR` with `__declspec(allocator)`, and suppress Clang's warning when the return type isn't a pointer or reference. * Remove workarounds for LLVM-43531 "clang-format damages 'alternative representations' for operators": Re-enable clang-format in the test which triggered the bug. * Remove workarounds for LLVM-38478 "clang -fno-ms-compatibility rejects Windows.h": Add -fno-ms-compatibility to the XXX_winsdk_XXX.lst files. (Yes, we still need these because the Windows SDK breaks `/Za`.)
StephanTLavavej
approved these changes
Apr 12, 2020
|
Awesome! Great work @CaseyCarter |
This reverts commit 35b11d5.
cbezault
approved these changes
Apr 13, 2020
StephanTLavavej
approved these changes
Apr 13, 2020
This was referenced Apr 14, 2020
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<yvals_core.h>changes:_HAS_CONDITIONAL_EXPLICITin C++14 mode (Only CUDA now requires the_HAS_CONDITIONAL_EXPLICIT == 0code paths)Unskip libc++ tests that need Concepts and/or
<=>std/tests/P0595R2_is_constant_evaluated: We no longer need suppress the warning Clang 9 emits when it sees the suppression for the warning Clang 10 emits in this test ;)std/tests/VSO_0157762_feature_test_macros: Remove Clang 9 supportstd/tests/concepts_matrix.lst: This is now simply a copy ofusual_latest_matrix.lstwith the/BElines (EDG configs) commented out. (i.e., we now run the Concepts tests with Clang as well as MSVC.)Remove workarounds for LLVM-38491 "clang-cl should accept __declspec(allocator)": Replace uses of
_DECLSPEC_ALLOCATORwith__declspec(allocator), and suppress Clang's warning when the return type isn't a pointer or reference.Remove workarounds for LLVM-43531 "clang-format damages 'alternative representations' for operators": Re-enable clang-format in the test which triggered the bug.
Remove workarounds for LLVM-38478 "clang -fno-ms-compatibility rejects Windows.h": Add -fno-ms-compatibility to the XXX_winsdk_XXX.lst files. (Yes, we still need these because the Windows SDK breaks
/Za.)[This is a dual of internal MSVC-PR-241460.]