Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect width that occurred when formatting a floating number in the locale specific form #4421

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

grcm10
Copy link
Contributor

@grcm10 grcm10 commented Feb 24, 2024

Fixes #4316

@grcm10 grcm10 requested a review from a team as a code owner February 24, 2024 09:31
@frederick-vs-ja

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej added bug Something isn't working format C++20/23 format labels Feb 24, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 29, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2a052a6 into microsoft:main Feb 29, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for fixing this runtime correctness bug and unblocking more libcxx tests! 🐞 ⚡ 😻

@grcm10 grcm10 deleted the format_width_issue branch March 2, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working format C++20/23 format
Projects
Archived in project
3 participants