-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LWG-2309 mutex::lock()
should not throw device_or_resource_busy
#3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Feb 15, 2023
StephanTLavavej
approved these changes
Feb 15, 2023
barcharcraz
reviewed
Feb 16, 2023
Merged
barcharcraz
approved these changes
Feb 16, 2023
StephanTLavavej
approved these changes
Feb 16, 2023
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for implementing one of the oldest outstanding LWG issues! 🎉 🚀 🔒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75. Fixes #3407.
This PR is currently subject to further changes, but decision is probably needed.
resource_deadlock_would_occur
should be thrown in the UB case; POSIX specifiesEAGAIN
(corresponding toresource_unavailable_try_again
) on ownership level overflowing. While @BillyONeal preferredabort()
for UB, and mentioned that SG1 suggestedterminate()
for overflowing (which, however, needs another LWG issue).mutex::lock
andrecursive_mutex::lock
because they have entirely different failing cases (same fortry_lock
). I guess they should be different functions.mutex.cpp
, although this will affect redist.recursive_timed_mutex
. While operations ofrecursive_mutex
were far faster, they still took over 1 minute to run.The extremely time-consuming test program: