Enhancements for future and shared_future
#3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil-ms
suggested changes
Dec 12, 2022
strega-nil-ms
added
bug
Add noexcept to _Deleter_base::_Delete, _State_deleter::_Delete, _Retain, and_Release.
strega-nil-ms
approved these changes
Dec 13, 2022
CaseyCarter
suggested changes
Dec 14, 2022
In constructors we can expect that `this != _STD addressof(_Other)`, so the refactorization seems worthy.
CaseyCarter
approved these changes
Dec 14, 2022
CaseyCarter
approved these changes
Dec 14, 2022
StephanTLavavej
approved these changes
Dec 15, 2022
|
Thanks - this is riskier than the average PR, but I think it preserves ABI and is a worthy improvement. I've pushed a couple of tiny changes to the test - a trivial naming nitpick (which I wouldn't have bothered with by itself), and a line to verify that the empty-braces type trait can report both |
CaseyCarter
approved these changes
Dec 15, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for noticing the nonconformance here and carefully improving things! 🕵️ 😻 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is making some enhancements for
<future>.std::is_nothrow_move_assignable_v<std::shared_future<void>>isfalsein MSVC STL (Godbolt link), which is non-conforming. This PR fixes this bug by making internal functionsnoexcept(inspired by Mark constructors that do not throw exceptions as noexcept #3278) and some special member functions defaulted.std::future<T> ft(another_future, {});(whereanother_futureis of typestd::future<T>orstd::shared_future<T>) (Godbolt link). This PR forbids such definitions - because I think the internal constructors shouldn't be directly touched when no _Ugly name is explicitly specified, although the status quo is conforming due to [member.functions]/2._Copy_fromand_Move_fromof_State_managerinto constructors and assignment operators, and simply the codes - this is making the implementation code shorter.