<algorithm>: find/count vectorize moar
#3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil-ms
force-pushed
the
find-count-vectorize-moar
branch
from
d9ae82d to
29020e3
Compare
barcharcraz
suggested changes
Dec 7, 2022
StephanTLavavej
requested changes
Dec 10, 2022
strega-nil-ms
commented
Dec 10, 2022
tests/std/tests/Dev11_0316853_find_memchr_optimization/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev11_0316853_find_memchr_optimization/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Dec 13, 2022
|
I pushed changes to clarify a comment and fix repeated test lines. @barcharcraz , the changes you requested have been made - you can re-review if you have time, or we can dismiss your stale review if you're busy. |
CaseyCarter
approved these changes
Dec 13, 2022
CaseyCarter
approved these changes
Dec 14, 2022
barcharcraz
approved these changes
Dec 14, 2022
StephanTLavavej
approved these changes
Dec 15, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving these optimizations!: 🐆 🐇 🏎️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3249
Depends on #3247