Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<algorithm>: count() could use vectorization in C++14/C++17 #3262

Merged
merged 1 commit into from
Dec 6, 2022
Merged

<algorithm>: count() could use vectorization in C++14/C++17 #3262

merged 1 commit into from
Dec 6, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Dec 4, 2022 •
edited
Loading

@fsb4000 fsb4000 requested a review from a team as a code owner December 4, 2022 01:17
@StephanTLavavej StephanTLavavej added the performance Must go faster label Dec 4, 2022
@fsb4000 fsb4000 changed the title <algorithm>: count() could use vectorization in C++14/C++17 <algorithm>::count() could use vectorization in C++14/C++17 Dec 4, 2022
@StephanTLavavej
Copy link
Member

Thanks! This should merge cleanly with #3247.

@StephanTLavavej StephanTLavavej changed the title <algorithm>::count() could use vectorization in C++14/C++17 <algorithm>: count() could use vectorization in C++14/C++17 Dec 5, 2022
@StephanTLavavej StephanTLavavej self-assigned this Dec 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6059e75 into microsoft:main Dec 6, 2022
@StephanTLavavej
Copy link
Member

Thanks for fixing and verifying this logic! 🛠️ 🚀 ✅

@fsb4000 fsb4000 deleted the fix3245 branch December 7, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<algorithm>: count() is missing vectorization opportunities in C++14/17
3 participants
@fsb4000 @StephanTLavavej @strega-nil-ms