-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_STD
-qualify _Ugly
non-member function calls in <variant>
#3148
Conversation
Partially addresses microsoft#140
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I've had to push an additional commit to fix internal test failures with |
I'm the last person you'll have to convince that we should do any extra work where |
Thanks for investigating and fixing this! 🕵️ 🛠️ 🎉 |
Qualifies calls to namespace-scope functions in
<variant>
, and enables the libc++ ADL test that now passes.Partially addresses #140