Port more MSBuild refactoring #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal MSVC-PR-425243. Note that that PR must target `prod/be`, so this will result in temporary divergence between microsoft/STL's GitHub repo and the internal `prod/fe` branch (which we usually keep binary-identical at all times). I believe that this is tolerable because the `stl/msbuild` files change so rarely, and even if we do need to make changes (e.g. adding a new source file), there should be no major conflicts.
strega-nil-ms
approved these changes
Sep 29, 2022
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
…internal MSVC-PR-425243. (microsoft#3133) Note that that PR must target `prod/be`, so this will result in temporary divergence between microsoft/STL's GitHub repo and the internal `prod/fe` branch (which we usually keep binary-identical at all times). I believe that this is tolerable because the `stl/msbuild` files change so rarely, and even if we do need to make changes (e.g. adding a new source file), there should be no major conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the
src/vctools/crt/githubchanges from Andrew Dean's internal MSVC-PR-425243.Note that that PR must target
prod/be, so this will result in temporary divergence between microsoft/STL's GitHub repo and the internalprod/febranch (which we usually keep binary-identical at all times). I believe that this is tolerable because thestl/msbuildfiles change so rarely, and even if we do need to make changes (e.g. adding a new source file), there should be no major conflicts.