Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constexprize bind_front and bind_back tests #3117

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Constexprize bind_front and bind_back tests #3117

merged 5 commits into from
Sep 22, 2022

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Sep 20, 2022 •
edited
Loading

Closes #968.

This PR constexprizes already existing tests and adds extra PMF test for bind_back.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner September 20, 2022 19:39
@StephanTLavavej StephanTLavavej mentioned this pull request Sep 20, 2022
Closed
@StephanTLavavej StephanTLavavej added the test Related to test code label Sep 20, 2022
StephanTLavavej
StephanTLavavej reviewed Sep 22, 2022
View reviewed changes
tests/std/tests/P2387R3_bind_back/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2387R3_bind_back/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2387R3_bind_back/test.cpp Show resolved Hide resolved
tests/std/tests/P0356R5_bind_front/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks, this looks great! 😻 I pushed some nitpicky changes, and a minor expansion of test coverage (ensuring we invoke both binders with reference_wrappers).

✅ No modules impact - test-only changes.

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 35078f3 into microsoft:main Sep 22, 2022
@StephanTLavavej
Copy link
Member

Thanks for finding this long-ago-filed issue and improving the test coverage here! ✅ 😻 🎉

@JMazurkiewicz JMazurkiewicz deleted the constexpr_bind_front_test branch September 22, 2022 23:15
CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@JMazurkiewicz @StephanTLavavej @CaseyCarter
Constexprize bind_front and bind_back tests (microsoft#3117)
9945328 
Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: Further constexprize P0356R5_bind_front after std::string is constexpr
3 participants
@JMazurkiewicz @StephanTLavavej @strega-nil-ms