Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3715: view_interface::empty is overconstrained #2946

Merged
merged 20 commits into from
Jul 28, 2022
Merged

Implement LWG-3715: view_interface::empty is overconstrained #2946

merged 20 commits into from
Jul 28, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Towards #2872.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 26, 2022 13:08
@frederick-vs-ja frederick-vs-ja mentioned this pull request Jul 26, 2022
Closed
26 tasks
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Jul 26, 2022
@frederick-vs-ja
Try a strange fix
5f3026d 
When V is not forward_range, chunk_view is not const-iterable despite the properties of const V.
@StephanTLavavej
Copy link
Member

Thanks! I pushed a truly trivial style change, for which I feel bad about spending a whole test pass in the CI system 😹

@StephanTLavavej StephanTLavavej self-assigned this Jul 27, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 06e7769 into microsoft:main Jul 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 😻 😻 😻 😻 😻 😻

@frederick-vs-ja frederick-vs-ja deleted the lwg-3715 branch July 28, 2022 03:53
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@frederick-vs-ja @StephanTLavavej @fsb4000
Implement LWG-3715: view_interface::empty is overconstrained (micro…
81d7eb6 
…soft#2946)

Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter @strega-nil-ms