-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow %x
for formatting year_month_day
#2762
Conversation
…_month_weekday, year_month_weekday_last
I believe that this is correct (although the Standard is unusually elliptical in this area, these types do provide the necessary information). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Ideally, we would test the locale specific orderings, but with current test coverage this looks like a strict improvement, even if the locale stuff were to be broken so I don't feel it needs those tests to be merged.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing this chronat bug! 📅 ✏️ 🎉 |
Co-authored-by: Stephan T. Lavavej <[email protected]>
Fixes #2761
I'm not sure if it's correct.
C++ standard is unclear: https://eel.is/c++draft/time.format#6
But cppreference says that
%x
is supported for year_month_day, year_month_day_last, year_month_weekday and year_month_weekday_last