[copy_file] allow FILE_SHARE_*
#2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code does not allow other programs to hold read permissions on _Source or _Target when copy_options = overwrite_existing or skip_existing. We could very easily allow reading, and could also allow writing for skip_existing, except for a clever implementation of equivalent, so just switch to a dumb implementation of equivalent here.
strega-nil-ms
changed the title
FILE_SHARE_*
BillyONeal
reviewed
May 13, 2022
StephanTLavavej
requested changes
May 13, 2022
StephanTLavavej
requested changes
May 13, 2022
StephanTLavavej
approved these changes
May 13, 2022
miscco
reviewed
May 14, 2022
| return _Last_error; // real error, bail to the caller | ||
| } | ||
|
|
||
| #ifndef _CRT_APP |
There was a problem hiding this comment.
Can we simplify the else case to simply be return __std_win_error{...} and move the switch into here
There was a problem hiding this comment.
This is pre-existing code that's being extracted from __std_fs_get_file_id(). I see what you're suggesting, and the control flow transformation wouldn't be risky, but my general preference is to avoid significantly altering code when moving it (unless it's necessary). We can do this as a followup cleanup, since this doesn't affect correctness or performance.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 16, 2022
|
Thanks for teaching the STL how to play nice and share! 😹 📂 🎉 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: nicole mazzuca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code does not allow other programs to hold read permissions
on
_Sourceor_Targetwhencopy_options = overwrite_existing or skip_existing.
We could very easily allow reading, and could also allow writing for
skip_existing, except for a clever implementation of equivalent,
so just switch to a dumb implementation of equivalent here.
Fixes #2185