-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add format target to cmake #2671
add format target to cmake #2671
Conversation
they will have mixed CRLF/LF
also make sure that we don't add diff files in the future (this is a thing Nicole has done more times than she'd like to admit)
This comment was marked as outdated.
This comment was marked as outdated.
Looks great! I've verified the failure experiences in #2681 and #2682, and locally verified that CMake's printed messages are expected. The clang-format experience is a little different from the current one (have to click through to see the diff) but I'm ok with that behavioral change. I went ahead and pushed a message clarification to |
This comment was marked as resolved.
This comment was marked as resolved.
I'm mildly concerned that this will mean we spend a lot more time explaining to new users how to find the formatting diff, but we can wait to address it if and when it actually becomes a problem. |
Closing and reopening to fix the CLA check. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for improving this important part of our infrastructure ( 🎉 😻 🚀 |
This replaces the
parallelize.cpp
hack, as well as allows users to runformat
with CMake.Additionally, this publishes the diff, so that people without the specific version of clang-format on their machine can download the diff and apply it themselves.