Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _MSVC_STL_UPDATE #2634

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Update _MSVC_STL_UPDATE #2634

merged 1 commit into from
Apr 4, 2022

Conversation

epartakki
Copy link
Contributor

@epartakki epartakki commented Apr 3, 2022 •
edited by StephanTLavavej
Loading

Fixes #2631.

@epartakki epartakki requested a review from a team as a code owner April 3, 2022 03:47
@StephanTLavavej StephanTLavavej changed the title fixes #2631 Update _MSVC_STL_UPDATE Apr 3, 2022
@StephanTLavavej
Copy link
Member

Thanks! I've updated your PR title and description because GitHub's auto-linking of PRs to issues (such that merging the PR will close the issue) is activated only when the description contains the magic words. (Saying "Fixes X" in the PR title has no effect; saying "Fixes X" in a commit message creates just a "mention" in the issue, same as saying anything about X in a commit.)

We mirror PRs to an MSVC-internal repo and merge them simultaneously; I'll add your PR to the batch I'm currently working on, so it can be merged soon! 😸

@epartakki
Copy link
Contributor Author

Thanks! I've updated your PR title and description because GitHub's auto-linking of PRs to issues (such that merging the PR will close the issue) is activated only when the description contains the magic words. (Saying "Fixes X" in the PR title has no effect; saying "Fixes X" in a commit message creates just a "mention" in the issue, same as saying anything about X in a commit.)

We mirror PRs to an MSVC-internal repo and merge them simultaneously; I'll add your PR to the batch I'm currently working on, so it can be merged soon! 😸

That's good to know! Thank you so much @StephanTLavavej 😃

@StephanTLavavej StephanTLavavej self-assigned this Apr 3, 2022
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 4, 2022
@StephanTLavavej StephanTLavavej merged commit 52505b9 into microsoft:main Apr 4, 2022
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🚀 🎉 😺

This will ship in VS 2022 17.3 Preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to April 2022
3 participants
@epartakki @StephanTLavavej @fsb4000