Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change SFINAE constraint on construct_at (MSVC workaround) #2624

Merged
merged 8 commits into from
Jun 19, 2022
Merged

change SFINAE constraint on construct_at (MSVC workaround) #2624

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fda4ef8
MSVC workaround of construct_at constraint
fsb4000 Mar 29, 2022
2c70e9c
add DevCom issues numbers and better formatting
fsb4000 Mar 30, 2022
f6a075c
typo
fsb4000 Mar 30, 2022
8f5953c
Code review nitpicks.
StephanTLavavej Mar 30, 2022
02822f5
update DevCom bug number
fsb4000 Mar 31, 2022
5b7667d
Merge branch 'fix2620' of https://github.com/fsb4000/STL into fix2620
fsb4000 Mar 31, 2022
8247c4c
explicit
fsb4000 Mar 31, 2022
ceba9e4
Merge branch 'main' into fix2620
StephanTLavavej Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/std/tests/GH_002620_construct_at_workaround/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ using namespace std;

struct S {
int v;
S(int v) : v(v) {}
S(int v_) : v(v_) {}
fsb4000 marked this conversation as resolved.
Show resolved Hide resolved
S(const S&) = delete;
};

Expand All @@ -20,7 +20,7 @@ union U {

struct copy_elider {
operator S() const {
return S(42);
return S{42};
}
};

Expand Down