Implement P2441R2 views::join_with #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Mar 28, 2022
miscco
reviewed
Mar 28, 2022
miscco
reviewed
Mar 28, 2022
miscco
reviewed
Mar 28, 2022
Co-authored-by: Michael Schellenberger Costa <[email protected]>
Co-authored-by: Michael Schellenberger Costa <[email protected]>
Co-authored-by: Michael Schellenberger Costa <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
miscco
reviewed
Mar 29, 2022
StephanTLavavej
requested changes
Apr 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Jun 14, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Michael Schellenberger Costa <[email protected]>
StephanTLavavej
approved these changes
Jun 15, 2022
StephanTLavavej
approved these changes
Jun 17, 2022
|
I've pushed a merge with |
|
I'm speculatively mirroring this to the MSVC-internal repo. Further changes can be pushed, but please notify me. |
CaseyCarter
approved these changes
Jun 19, 2022
miscco
approved these changes
Jun 19, 2022
StephanTLavavej
approved these changes
Jun 19, 2022
|
Thanks for implementing this C++23 ranges feature! ✅ 😻 🎉 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Michael Schellenberger Costa <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]> Co-authored-by: Casey Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements P2441R2
views::join_with.Fixes #2538.
I need suggestions on test. This view depends on the category (input/forward/bidirectional), commonness, and element type of three ranges (outer, inner, pattern). Currently I simply copy the
instantiation_testfunction fromP0896R4_views_join, but it might be desirable to also test non-bidirectional_rangeor non-common_rangepatterns.