-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ranges::split_view #1731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github, why can't I "Request Changes" on my own PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its been a time since I really looked at a view, so I hope this are not too dumb questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Update list of implemented proposals I have verified that all proposals and LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
Update list of implemented proposals I have verified that all 23 proposals and 35 LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
Thanks for your contribution! (The pun is pretty subtle here: I'm thanking myself, as if I had a split personality.) |
in_in_result
,ranges::_Find_unchecked
,ranges::mismatch
, and_Require_constant
up from<algorithm>
into<xulility>
sosplit_view
can use them without including all of<algorithm>
in<ranges>
. Moves_Convertible_from
up from<xmemory>
to<xutility>
for the same reason.Partially addresses #39.