Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ranges::split_view #1731

Merged
merged 9 commits into from
Mar 18, 2021
Merged

Conversation

CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Mar 11, 2021

  • Moves in_in_result, ranges::_Find_unchecked, ranges::mismatch, and _Require_constant up from <algorithm> into <xulility> so split_view can use them without including all of <algorithm> in <ranges>. Moves _Convertible_from up from <xmemory> to <xutility> for the same reason.

Partially addresses #39.

@CaseyCarter CaseyCarter requested a review from a team as a code owner March 11, 2021 22:03
@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Mar 11, 2021
@CaseyCarter CaseyCarter mentioned this pull request Mar 11, 2021
Copy link
Contributor Author

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github, why can't I "Request Changes" on my own PR?

stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_split/env.lst Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Mar 12, 2021
stl/inc/xutility Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Mar 12, 2021
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been a time since I really looked at a view, so I hope this are not too dumb questions

stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
Copy link
Member

@MahmoudGSaleh MahmoudGSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Mar 17, 2021
Update list of implemented proposals

I have verified that all proposals and LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Mar 17, 2021
Update list of implemented proposals

I have verified that all 23 proposals and 35 LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
@CaseyCarter CaseyCarter self-assigned this Mar 17, 2021
@CaseyCarter CaseyCarter merged commit 038e07b into microsoft:main Mar 18, 2021
@CaseyCarter CaseyCarter deleted the split_view branch March 18, 2021 20:25
@CaseyCarter
Copy link
Contributor Author

Thanks for your contribution!

(The pun is pretty subtle here: I'm thanking myself, as if I had a split personality.)

@CaseyCarter CaseyCarter removed their assignment Mar 18, 2021
CaseyCarter added a commit that referenced this pull request Mar 18, 2021
Update list of implemented proposals

I have verified that all 23 proposals and 35 LWG issues listed in #39 are implemented either on main, in #1436, or in #1731.

Fixes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants