Implement ranges::uninitialized_meow #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hade some time at hand and added |
miscco
changed the title
miscco
changed the title
Closed
miscco
force-pushed
the
ranges_uninitialized_default_construct
branch
3 times, most recently
from
e1decd0 to
6136e62
Compare
miscco
commented
Aug 16, 2020
CaseyCarter
force-pushed
the
ranges_uninitialized_default_construct
branch
from
de904c7 to
7ee1c3e
Compare
CaseyCarter
suggested changes
Aug 27, 2020
* `ranges::uninitialized_default_construct`, `ranges::uninitialized_default_construct_n` * `ranges::uninitialized_value_construct`, `ranges::uninitialized_value_construct_n` * `ranges::uninitialized_fill`, `ranges::uninitialized_fill_n` * `ranges::uninitialized_copy`, `ranges::uninitialized_copy_n` * `ranges::uninitialized_move_n`
miscco
commented
Aug 31, 2020
miscco
force-pushed
the
ranges_uninitialized_default_construct
branch
from
7ee1c3e to
c925844
Compare
|
@CaseyCarter Thanks a lot for the comments. I incorporated them and will have a look at additional test coverage soonTM |
|
This needs to be merged with recent changes to |
CaseyCarter
suggested changes
Sep 17, 2020
tests/std/tests/P0896R4_ranges_alg_uninitialized_copy_n/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0896R4_ranges_alg_uninitialized_value_construct/test.cpp
Show resolved
Hide resolved
tests/std/tests/P0896R4_ranges_alg_uninitialized_default_construct/test.cpp
Show resolved
Hide resolved
tests/std/tests/P0896R4_ranges_alg_uninitialized_value_construct/test.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
approved these changes
Sep 17, 2020
StephanTLavavej
requested changes
Sep 18, 2020
There was a problem hiding this comment.
I believe I found some minor issues but @CaseyCarter should verify as my brain is running low on caffeine.
tests/std/tests/P0896R4_ranges_alg_uninitialized_copy_n/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0896R4_ranges_alg_uninitialized_move_n/test.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephan T. Lavavej <[email protected]>
StephanTLavavej
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Looks good to me now except for one unresolved comment. @CaseyCarter feel free to move this to Ready To Merge.
tests/std/tests/P0896R4_ranges_alg_uninitialized_move_n/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Sep 18, 2020
CaseyCarter
approved these changes
Sep 18, 2020
AdamBucior
reviewed
Sep 19, 2020
Co-authored-by: Adam Bucior <[email protected]>
|
@miscco @CaseyCarter I applied @AdamBucior's suggested change after verifying that no other occurrences were affected (either in this PR or in the codebase). We have a new convention to remember! 😺 |
|
Thanks a lot, I thought I found all of those |
CaseyCarter
approved these changes
Sep 22, 2020
|
Thanks for constructing so many cat noises in uninitialized memory! 😺 😸 🐱 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the
uninitialized_default_construct{_n}algorithms to ranges.NOTE: This is based upon the
uninitialized_movePR as that PR is quite advanced and the merge conflicts by replicating bits of it didnt seem worth it. So it makes sense to only look at the final commit