Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Single qubit gates #185

Merged
merged 9 commits into from
Nov 1, 2019
Merged

Conversation

flockofonions
Copy link
Contributor

Added a tutorial explaining Single Qubit Gates

Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the first batch of comments on this PR, up to (but not including) Q# demo.

" <th style=\"text-align:center; border:1px solid\">Ket-Bra</th>\n",
" <th style=\"text-align:center; border:1px solid\">Applying to $|\\psi\\rangle$</th>\n",
" <th style=\"text-align:center; border:1px solid\">Applying to basis states</th>\n",
" <th style=\"text-align:center; border:1px solid\">Q# Documentation</th>\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add one more column showing the gate representation in circuit notation? Or would it just confuse the reader, since we're not talking about circuits anywhere in the tutorials?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark this as a future improvement - it probably makes more sense to do a separate tutorial on circuit representation, similarly to a separate tutorial on Bloch sphere.

Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished the review pass. Looks good overall, seems a bit lengthy but with a bit of reorganization it can be trimmed without losing any content.

Please let me know when you've addressed all the comments and the PR is ready for the final round of review.

Thank you!

Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed the comments and added the tutorial to the lists, so it should be ready to merge now.

Thank you!

@tcNickolas tcNickolas merged commit b85a81c into microsoft:master Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants