This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Single qubits #184
Merged
Single qubits #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcNickolas
reviewed
Oct 20, 2019
tcNickolas
suggested changes
Oct 21, 2019
There was a problem hiding this comment.
I've finished the review pass. Looks good overall, and seems to be just the right length and content - most comments are wording suggestions.
Please let me know when you've addressed all the comments and the PR is ready for the final round of review.
Thank you!
tutorials/Qubit/Qubit.ipynb
Outdated
| "\n", | ||
| "$\\alpha|0\\rangle + \\beta|1\\rangle$ is equivalent to $e^{i\\theta}\\big(\\alpha|0\\rangle + \\beta|1\\rangle\\big)$.\n", | ||
| "\n", | ||
| "In a situation like that, $\\theta$ is known as the quantum system's **global phase**, **unobservable phase**, or **hidden phase**." |
There was a problem hiding this comment.
It would be neat to tie this to Q# with a small demo similar to the previous one. Two things come to mind:
- Explanations of the phase and the direction columns in DumpMachine output.
- Some notes on DumpMachine showing the state up to some global phase factor, and with the qubit acquiring -1 phase - usually this can be done by applying some gates and then some more gates that should undo the first ones. This is also one of the frequently asked questions about DumpMachine, so it it a good thing to call out.
Co-Authored-By: Mariia Mykhailova <[email protected]>
Co-Authored-By: Mariia Mykhailova <[email protected]>
|
Please let me know when this PR is ready for the final review. |
tcNickolas
approved these changes
Oct 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a tutorial explaining Qubits.