Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to find instruments from parameter chain #6616

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

picarro-yren
Copy link
Contributor

This PR adds two new methods to find instruments of specific type in a parameter chain.

@picarro-yren picarro-yren requested a review from a team as a code owner November 12, 2024 21:23
@picarro-yren
Copy link
Contributor Author

picarro-yren commented Nov 12, 2024

@microsoft-github-policy-service agree

Copy link
Contributor

@trevormorgan trevormorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a nice addition to qcodes!

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (3244b56) to head (68f0f72).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6616      +/-   ##
==========================================
+ Coverage   69.35%   69.37%   +0.01%     
==========================================
  Files         340      340              
  Lines       31279    31293      +14     
==========================================
+ Hits        21694    21708      +14     
  Misses       9585     9585              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@picarro-yren picarro-yren added this pull request to the merge queue Nov 14, 2024
Merged via the queue into microsoft:main with commit 6a2ed34 Nov 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants